On Wed, 14 Dec 2022 at 09:34, <[email protected]> wrote: > > From: Pierre Gondois <[email protected]> > > Building the RdV1 platform fails when only providing the > '-D SECURE_STORAGE_ENABLE' flag due to MmUnblockMemoryLib missing. > > Signed-off-by: Pierre Gondois <[email protected]> > --- > Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc > b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc > index 81764368a0b7..b36c130722b6 100644 > --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc > +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc > @@ -38,7 +38,7 @@ [LibraryClasses.common] > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > > ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf > TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf > -!if $(SECURE_BOOT_ENABLE) == TRUE > +!if ($(SECURE_BOOT_ENABLE) == TRUE) || ($(SECURE_STORAGE_ENABLE) == TRUE) > > MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf > !endif >
Thanks for the fix. However, if MmUnblockMemoryLib is just a library resolution that is always satisfied by the same implementation, couldn't we drop the conditional altogether? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#97361): https://edk2.groups.io/g/devel/message/97361 Mute This Topic: https://groups.io/mt/95662728/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
