Is there anything blocking this patch from being merged?
-----Original Message-----
From: Michael Kubacki <mikub...@linux.microsoft.com>
Sent: Wednesday, November 30, 2022 4:07 PM
To: devel@edk2.groups.io; Jeshua Smith <jesh...@nvidia.com>
Cc: michael.d.kin...@intel.com; sean.bro...@microsoft.com
Subject: Re: [edk2-devel] [PATCH v3] UnitTestFrameworkPkg/UnitTestLib: Print
expected Status on ASSERT fail
External email: Use caution opening links or attachments
Reviewed-by: Michael Kubacki <michael.kuba...@microsoft.com>
On 11/30/2022 6:02 PM, Jeshua Smith via groups.io wrote:
> Update the UnitTestAssertStatusEqual error message to print out the
> expected value in addition to the seen value.
>
> Signed-off-by: Jeshua Smith <jesh...@nvidia.com>
> ---
> UnitTestFrameworkPkg/Library/UnitTestLib/AssertCmocka.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/AssertCmocka.c
> b/UnitTestFrameworkPkg/Library/UnitTestLib/AssertCmocka.c
> index dc05bbd438..0d8e36c938 100644
> --- a/UnitTestFrameworkPkg/Library/UnitTestLib/AssertCmocka.c
> +++ b/UnitTestFrameworkPkg/Library/UnitTestLib/AssertCmocka.c
> @@ -290,7 +290,7 @@ UnitTestAssertStatusEqual (
> {
> CHAR8 TempStr[MAX_STRING_SIZE];
>
> - snprintf (TempStr, sizeof (TempStr),
> "UT_ASSERT_STATUS_EQUAL(%s:%p)", Description, (VOID *)Status);
> + snprintf (TempStr, sizeof (TempStr), "UT_ASSERT_STATUS_EQUAL(%s:%p
> + expected:%p)", Description, (VOID *)Status, (VOID *)Expected);
> _assert_true ((Status == Expected), TempStr, FileName,
> (INT32)LineNumber);
>
> return (Status == Expected);
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97374): https://edk2.groups.io/g/devel/message/97374
Mute This Topic: https://groups.io/mt/95370662/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
