On Tue, Jan 03, 2023 at 05:05:39PM +0100, Laszlo Ersek wrote: > I suggest that Gerd be notified about all UefiCpuPkg patches, so he may > take a quick look at, or (by his preference) even test, the proposed > change, in a genuine QEMU/KVM environment. > > Assuming this patch is accepted -- subsequently, please *wait* for Gerd's > approval on UefiCpuPkg patches, before merging them. > > Notes: > > - It's perfectly fine for a reviewer to give an A-b just so the review > process be unblocked, if they don't have anything to add, or don't have > time to review or test in detail. The point is that someone outside of > Intel should *consistently get a chance* to raise concerns about > UefiCpuPkg patches before they are merged. > > - My A-b's and R-b's on UefiCpuPkg patches were never supposed to be > "sufficient", only "necessary", for merging. The intent is the same > here, with Gerd's designation as a reviewer. > > Cc: Andrew Fish <af...@apple.com> > Cc: Eric Dong <eric.d...@intel.com> > Cc: Gerd Hoffmann <kra...@redhat.com> > Cc: Leif Lindholm <quic_llind...@quicinc.com> > Cc: Michael D Kinney <michael.d.kin...@intel.com> > Cc: Rahul Kumar <rahul1.ku...@intel.com> > Cc: Ray Ni <ray...@intel.com> > Signed-off-by: Laszlo Ersek <ler...@redhat.com>
Acked-by: Gerd Hoffmann <kra...@redhat.com> take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#97933): https://edk2.groups.io/g/devel/message/97933 Mute This Topic: https://groups.io/mt/96030658/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
