Thanks for the review! -----Original Message----- From: Ni, Ray <[email protected]> Sent: Friday, January 6, 2023 9:01 AM To: Oram, Isaac W <[email protected]>; Chang, Hunter <[email protected]>; [email protected] Cc: Chaganty, Rangasai V <[email protected]>; S, Ashraf Ali <[email protected]> Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h
Isaac, So, no public doc defines the SMBIOS entry: SMBIOS_TABLE_TYPE_OEM_INTEL_FVI? Then, I am ok with the new addition 0xDD. Reviewed-by: Ray Ni <[email protected]> > -----Original Message----- > From: Oram, Isaac W <[email protected]> > Sent: Friday, January 6, 2023 3:26 AM > To: Ni, Ray <[email protected]>; Chang, Hunter > <[email protected]>; [email protected] > Cc: Chaganty, Rangasai V <[email protected]>; S, Ashraf > Ali <[email protected]> > Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE > definition in FirmwareVersionInfo.h > > Ray, > > I think it is ok because this file is "Intel common definitions for an > OEM defined SMBIOS table structure". We could say that the folder > name is wrong or the whole file is in the wrong place. But this addition > seems consistent with the rest of the file contents. > > Regards, > Isaac > > -----Original Message----- > From: Ni, Ray <[email protected]> > Sent: Thursday, January 5, 2023 1:39 AM > To: Chang, Hunter <[email protected]>; [email protected] > Cc: Chaganty, Rangasai V <[email protected]>; Oram, Isaac > W <[email protected]>; S, Ashraf Ali <[email protected]> > Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE > definition in FirmwareVersionInfo.h > > If it's not defined by any spec, it's probably not a good idea to put the > definition in an industry header file. > > > > -----Original Message----- > > From: Chang, Hunter <[email protected]> > > Sent: Thursday, January 5, 2023 3:54 PM > > To: Ni, Ray <[email protected]>; [email protected] > > Cc: Chaganty, Rangasai V <[email protected]>; Oram, > > Isaac W <[email protected]>; S, Ashraf Ali > > <[email protected]> > > Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE > > definition in FirmwareVersionInfo.h > > > > It is from Sipkg.dec > > gSiPkgTokenSpaceGuid.PcdFviSmbiosType|0xDD > > > > 0x00~0x7F are reserved for and defined by smbios spec 0x80~0xFF are > > available for system- and OEM-specific information > > > > I think there is no spec define 0xDD. > > > > -----Original Message----- > > From: Ni, Ray <[email protected]> > > Sent: Thursday, January 5, 2023 3:05 PM > > To: Chang, Hunter <[email protected]>; [email protected] > > Cc: Chaganty, Rangasai V <[email protected]>; Oram, > > Isaac W <[email protected]>; S, Ashraf Ali > > <[email protected]> > > Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE > > definition in FirmwareVersionInfo.h > > > > Which spec defines 0xDD? > > > > > -----Original Message----- > > > From: Chang, Hunter <[email protected]> > > > Sent: Wednesday, January 4, 2023 3:47 PM > > > To: [email protected] > > > Cc: Chang, Hunter <[email protected]>; Ni, Ray > > > <[email protected]>; Chaganty, Rangasai V > > > <[email protected]>; Oram, Isaac W > > > <[email protected]>; S, Ashraf Ali <[email protected]> > > > Subject: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE > > > definition in FirmwareVersionInfo.h > > > > > > From: Hunter Chang <[email protected]> > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4242 > > > > > > Define a macro for SmbiosFeaturePkg usage which named > > > INTEL_FVI_SMBIOS_TYPE and initialized to 0xDD in > > > IndustryStandard/FirmwareVersionInfo.h > > > > > > Signed-off-by: Hunter Chang <[email protected]> > > > > > > Cc: Ray Ni <[email protected]> > > > Cc: Rangasai V Chaganty <[email protected]> > > > Cc: Isaac Oram <[email protected]> > > > Cc: Ashraf Ali S <[email protected]> > > > --- > > > > > > Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVer > > > si > > > on > > > Info.h | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git > > > a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareV > > > er > > > si > > > onInfo.h > > > b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareV > > > er > > > si > > > onInfo.h > > > index b30bc3f9e7..466cb8e7d2 100644 > > > --- > > > a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareV > > > er > > > si > > > onInfo.h > > > +++ b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/Firmw > > > +++ ar > > > +++ eV > > > +++ ersionInfo.h > > > @@ -18,6 +18,7 @@ > > > #include <IndustryStandard/SmBios.h> > > > > > > > > > > > > #define INTEL_FIRMWARE_VERSION_INFO_GROUP_NAME "Firmware Version Info" > > > > > > +#define INTEL_FVI_SMBIOS_TYPE 0xDD > > > > > > > > > > > > #pragma pack(1) > > > > > > > > > > > > -- > > > 2.26.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#98113): https://edk2.groups.io/g/devel/message/98113 Mute This Topic: https://groups.io/mt/96046622/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
