[AMD Official Use Only - General] OK, I see.
So Isaac, could you please help to check below series of patch? https://edk2.groups.io/g/devel/message/97769?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3ACreated%2C%2CAdd+NULL+instance+library%2C20%2C2%2C0%2C95915689 I will check with MdeMoudulePkg maintainers to see if they are ok with these IPMI patch sets once you give the reviewed-by to above one. We will need them to merge the code. Thanks Abner > -----Original Message----- > From: Oram, Isaac W <isaac.w.o...@intel.com> > Sent: Thursday, January 12, 2023 7:15 AM > To: Chang, Abner <abner.ch...@amd.com>; devel@edk2.groups.io > Cc: Desimone, Nathaniel L <nathaniel.l.desim...@intel.com>; Kinney, > Michael D <michael.d.kin...@intel.com>; Gao, Liming > <gaolim...@byosoft.com.cn>; Liu, Zhiguang <zhiguang....@intel.com>; > Nickle Wang <nick...@nvidia.com>; Igor Kulchytskyy <ig...@ami.com> > Subject: RE: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for > Redfish > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > I believe that this edk2-platforms series is dependent on the changes in > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk > 2.groups.io%2Fg%2Fdevel%2Fmessage%2F98051&data=05%7C01%7CAbner. > Chang%40amd.com%7C1e8dfb9b78f245437e6f08daf4299d00%7C3dd8961fe4 > 884e608e11a82d994e183d%7C0%7C0%7C638090756807764009%7CUnknown > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha > WwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=XZQBaA%2FaxIWEbRSD > DVpO7qznlraJEh4UjeHAV30qu1E%3D&reserved=0 and they have not been > merged yet. > I had those changes under review in the branch I used for testing this patch > series for edk2-platforms so my testing missed this. > > Regards, > Isaac > > -----Original Message----- > From: Chang, Abner <abner.ch...@amd.com> > Sent: Thursday, January 5, 2023 6:27 PM > To: Oram, Isaac W <isaac.w.o...@intel.com>; devel@edk2.groups.io > Cc: Desimone, Nathaniel L <nathaniel.l.desim...@intel.com>; Kinney, > Michael D <michael.d.kin...@intel.com>; Gao, Liming > <gaolim...@byosoft.com.cn>; Liu, Zhiguang <zhiguang....@intel.com>; > Nickle Wang <nick...@nvidia.com>; Igor Kulchytskyy <ig...@ami.com> > Subject: RE: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for > Redfish > > [AMD Official Use Only - General] > > Hi Isaac, > I am not quite understand, this patch set should be independent of edk2. > What do you mean the edk2 changes were pushed first? Or IpmiFeaturePkg > is good now? > > Abner > > > -----Original Message----- > > From: Oram, Isaac W <isaac.w.o...@intel.com> > > Sent: Friday, January 6, 2023 1:42 AM > > To: devel@edk2.groups.io; Oram, Isaac W <isaac.w.o...@intel.com>; > > Chang, Abner <abner.ch...@amd.com> > > Cc: Desimone, Nathaniel L <nathaniel.l.desim...@intel.com>; Kinney, > > Michael D <michael.d.kin...@intel.com>; Gao, Liming > > <gaolim...@byosoft.com.cn>; Liu, Zhiguang <zhiguang....@intel.com>; > > Nickle Wang <nick...@nvidia.com>; Igor Kulchytskyy <ig...@ami.com> > > Subject: RE: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for > > Redfish > > > > Caution: This message originated from an External Source. Use proper > > caution when opening attachments, clicking links, or responding. > > > > > > Series pushed as: 28f3ce4a6a251de327b8d19c3316a654887f4f13.. > > f5da8af6befbfc655fd3e4cb899eda158dd9ede5 > > > > My apologies, I was sloppy and didn't ensure the edk2 changes were > > pushed first, so IpmiFeaturePkg build is currently broken pending > > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk > % > > > 2F&data=05%7C01%7CAbner.Chang%40amd.com%7C1e8dfb9b78f245437e6f > 08daf429 > > > 9d00%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6380907568077 > 64009%7 > > > CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJ > BTiI6Ik1 > > > haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=dqY%2FUy5q88%2B3 > GOiVpSkPSxHF > > Wlqma7DQKrgQiStT3ng%3D&reserved=0 > > > 2.groups.io%2Fg%2Fdevel%2Fmessage%2F97789being&data=05%7C01%7Ca > > > bner.chang%40amd.com%7C6301c092067c4f19a1b208daef441af4%7C3dd896 > > > 1fe4884e608e11a82d994e183d%7C0%7C0%7C638085373047816357%7CUnkn > > > own%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik > > > 1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=tBhHMIQhVL8AI3bof > > YIPHcTIzobpQ7lgZgwFJa0z0Gc%3D&reserved=0 being pushed. > > > > Regards, > > Isaac > > > > > > -----Original Message----- > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Isaac > > Oram > > Sent: Thursday, January 5, 2023 9:05 AM > > To: abner.ch...@amd.com; devel@edk2.groups.io > > Cc: Desimone, Nathaniel L <nathaniel.l.desim...@intel.com>; Kinney, > > Michael D <michael.d.kin...@intel.com>; Gao, Liming > > <gaolim...@byosoft.com.cn>; Liu, Zhiguang <zhiguang....@intel.com>; > > Nickle Wang <nick...@nvidia.com>; Igor Kulchytskyy <ig...@ami.com> > > Subject: Re: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for > > Redfish > > > > Series Reviewed-by: Isaac Oram <isaac.w.o...@intel.com> > > > > -----Original Message----- > > From: abner.ch...@amd.com <abner.ch...@amd.com> > > Sent: Thursday, January 5, 2023 8:01 AM > > To: devel@edk2.groups.io > > Cc: Oram, Isaac W <isaac.w.o...@intel.com>; Desimone, Nathaniel L > > <nathaniel.l.desim...@intel.com>; Kinney, Michael D > > <michael.d.kin...@intel.com>; Gao, Liming <gaolim...@byosoft.com.cn>; > > Liu, Zhiguang <zhiguang....@intel.com>; Nickle Wang > > <nick...@nvidia.com>; Igor Kulchytskyy <ig...@ami.com> > > Subject: [edk2-platforms][PATCH V2] IPMI changes for Redfish > > > > From: Abner Chang <abner.ch...@amd.com> > > > > In V2: Addressed the comments from Isaac. > > > > BZ# 4214 > > This patch adds IPMI functions for building up SMBIOS 42 record for > > the USB NIC host interface exposed by BMC. > > The corresponding updates on edk2 is in the separate pacth. > > > > This is the part I of upstream, the follow up patche sets are: > > - RedfishPlatformCredentialLib contributed by NVidia. > > - Relocate IpmiCommandLib.h from edk2-platforms > > to edk2/MdePkg. A NULL instance of IpmiCommandLib is created > > and located under MdePkg. With above, RedfishPkg doesn't have the > > dependence with edk2-platforms. The implementation of > IpmiCommandLib > > stays in edk2-platforms without relocation, which can be pulled in > > to platform DSC as needed. > > - PlatformHostInterfaceBmcUsbNic would be upstream to edk2-staging > > temporarily because some requirements are necessray to be spec out > > in the Redfish section in UEFI spec. > > > > Signed-off-by: Abner Chang <abner.ch...@amd.com> > > Cc: Isaac Oram <isaac.w.o...@intel.com> > > Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> > > Cc: Michael D Kinney <michael.d.kin...@intel.com> > > Cc: Liming Gao <gaolim...@byosoft.com.cn> > > Cc: Zhiguang Liu <zhiguang....@intel.com> > > Cc: Nickle Wang <nick...@nvidia.com> > > Cc: Igor Kulchytskyy <ig...@ami.com> > > > > Abner Chang (3): > > Features/IpmiFeaturePkg: Add IPMI functions > > IpmiFeaturePkg/IpmiCommandLib: Add IPMI functions > > IpmiFeaturePkg: Add reference of IpmiBaseLib > > > > .../IpmiFeaturePkg/IpmiFeaturePkg.dec | 5 ++ > > .../Include/Library/IpmiCommandLib.h | 62 +++++++++++++ > > .../IpmiCommandLib/IpmiCommandLibNetFnApp.c | 88 > > +++++++++++++++++++ > > .../IpmiCommandLibNetFnTransport.c | 43 +++++++++ > > 4 files changed, 198 insertions(+) > > > > -- > > 2.37.1.windows.1 > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#98337): https://edk2.groups.io/g/devel/message/98337 Mute This Topic: https://groups.io/mt/96074589/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
