Gerd, I saw Zhiguang and you had some conversation in V1 mail thread. Was below question answered in that conversation?
Any concern if I merge the patch? Thanks, Ray > -----Original Message----- > From: Gerd Hoffmann <kra...@redhat.com> > Sent: Wednesday, January 18, 2023 5:05 PM > To: Liu, Zhiguang <zhiguang....@intel.com> > Cc: devel@edk2.groups.io; Kumar, Rahul R <rahul.r.ku...@intel.com>; Zeng, > Star <star.z...@intel.com>; w...@sirius.home.kraxel.org; Wu, Jiaxin > <jiaxin...@intel.com>; Ni, Ray <ray...@intel.com>; Dong, Eric > <eric.d...@intel.com> > Subject: Re: [PATCH v2] UefiCpuPkg: Fix SMM code hangs when InitPaging > > On Wed, Jan 18, 2023 at 09:23:48AM +0800, Zhiguang Liu wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4246 > > > > In function InitPaging, NumberOfPml5Entries is calculated by below code > > NumberOfPml5Entries = (UINTN)LShiftU64 (1, SizeOfMemorySpace - 48); > > If the SizeOfMemorySpace is larger than 48, NumberOfPml5Entries will be > > larger than 1. However, this doesn't make sense if the hardware doesn't > > support 5 level page table. > > ... if 5-level paging is not used. > > Hardware which does not support 5-level paging is limited to 48 anyway. > > This still does not explain why this fixes code hangs. > > take care, > Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#99383): https://edk2.groups.io/g/devel/message/99383 Mute This Topic: https://groups.io/mt/96345457/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
