Thanks Liming for reviewing this patch. Could you help push this change? Thanks Zhiguang
> -----Original Message----- > From: [email protected] <[email protected]> On Behalf Of > gaoliming via groups.io > Sent: Thursday, February 2, 2023 11:10 AM > To: Liu, Zhiguang <[email protected]>; [email protected]; Wang, > Jian J <[email protected]> > Cc: Ni, Ray <[email protected]> > Subject: 回复: [edk2-devel] [PATCH] MdeModulePkg: Disambiguate the > meaning of PcdDxeIplSwitchToLongMode > > It is good to me. Reviewed-by: Liming Gao <[email protected]> > > > -----邮件原件----- > > 发件人: Liu, Zhiguang <[email protected]> > > 发送时间: 2023年2月1日 13:28 > > 收件人: [email protected]; Liu, Zhiguang <[email protected]>; > > Gao, Liming <[email protected]>; Wang, Jian J > > <[email protected]> > > 抄送: Ni, Ray <[email protected]> > > 主题: RE: [edk2-devel] [PATCH] MdeModulePkg: Disambiguate the > meaning of > > PcdDxeIplSwitchToLongMode > > > > Hi Liming and Jian, > > > > What do you think about this patch? > > > > Thanks > > Zhiguang > > > > > -----Original Message----- > > > From: [email protected] <[email protected]> On Behalf Of > > > Zhiguang Liu > > > Sent: Monday, January 9, 2023 11:34 AM > > > To: [email protected] > > > Cc: Liu, Zhiguang <[email protected]>; Wang, Jian J > > > <[email protected]>; Gao, Liming <[email protected]>; Ni, > > > Ray <[email protected]> > > > Subject: [edk2-devel] [PATCH] MdeModulePkg: Disambiguate the > meaning > > > of PcdDxeIplSwitchToLongMode > > > > > > Literally, the meaning of PcdDxeIplSwitchToLongMode is clear, > > > indicating whether need switch to long mode when loading DxeCore. > > > However, the comments in dec are confusing for the case where PEI > > > core and DXE core are both in 64-bit. This patch makes it clear. > > > PcdDxeIplSwitchToLongMode is true only when PEI core is 32-bit, and > switch > > > to long mode to load 64-bit DXE core. In other cases, this PCD is false. > > > This also aligns with current usage in OvmfPkg. > > > > > > Cc: Jian J Wang <[email protected]> > > > Cc: Liming Gao <[email protected]> > > > Cc: Ray Ni <[email protected]> > > > Signed-off-by: Zhiguang Liu <[email protected]> > > > --- > > > MdeModulePkg/MdeModulePkg.dec | 4 +--- > > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > > > diff --git a/MdeModulePkg/MdeModulePkg.dec > > > b/MdeModulePkg/MdeModulePkg.dec index be5e829ca9..5e4535e353 > > > 100644 > > > --- a/MdeModulePkg/MdeModulePkg.dec > > > +++ b/MdeModulePkg/MdeModulePkg.dec > > > @@ -922,10 +922,8 @@ > > > > > > [PcdsFeatureFlag.IA32, PcdsFeatureFlag.X64] > > > ## Indicates if DxeIpl should switch to long mode to enter DXE phase. > > > - # It is assumed that 64-bit DxeCore is built in firmware if it > > > is > true; > > > otherwise 32-bit DxeCore > > > - # is built in firmware.<BR><BR> > > > # TRUE - DxeIpl will load a 64-bit DxeCore and switch to long > > mode to hand > > > over to DxeCore.<BR> > > > - # FALSE - DxeIpl will load a 32-bit DxeCore and perform stack > switch > > to > > > hand over to DxeCore.<BR> > > > + # FALSE - DxeIpl will load a 32-bit or 64-bit DxeCore and perform > > stack > > > switch to hand over to DxeCore.<BR> > > > # @Prompt DxeIpl switch to long mode. > > > > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|TRUE|B > > > OOLEAN|0x0001003b > > > > > > -- > > > 2.31.1.windows.1 > > > > > > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#99542): https://edk2.groups.io/g/devel/message/99542 Mute This Topic: https://groups.io/mt/96718851/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
