On Fri, Feb 03, 2023 at 08:59:06AM +0000, Wu, Jiaxin wrote:
> Hi Laszlo & Gerd,
>
> > SmmCpuFeaturesLibConstructor (
> > IN EFI_HANDLE ImageHandle,
> > IN EFI_SYSTEM_TABLE *SystemTable
> > )
> > {
> > + //
> > + // If gSmmBaseHobGuid found, means SmBase info has been relocated and
> > recorded
> > + // in the SmBase array.
> > + //
> > + mSmmCpuFeaturesSmmRelocated = (BOOLEAN)(GetFirstGuidHob
> > (&gSmmBaseHobGuid) != NULL);
> > +
>
> Do you agree just assert mSmmCpuFeaturesSmmRelocated is the false for OVMF?
Skip the indirection, just "ASSERT(GetFirstGuidHob(...) == NULL)".
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#99551): https://edk2.groups.io/g/devel/message/99551
Mute This Topic: https://groups.io/mt/96719404/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
