On Thu, 9 Feb 2023 at 11:27, Gerd Hoffmann <kra...@redhat.com> wrote: > > Known problem: the NOOPT builds fail due to PEI becoming too big. > > What is the reason for doing these NOOPT builds?
They are very useful for doing single step debugging with GDB. On ARM, I use the NOOPT builds fairly regularly. > I'm not sure what > value they provide. But the lack of LTO bloats the binaries with dead > code, which is a constant source of trouble ... > > v2 changes: > - turn on crypto driver support by default. > - left the config option in for now as fallback option. > When all goes as planned remove it one or two releases > later. > - fix various build problems. > > Gerd Hoffmann (10): > CryptoPkg: move Driver PCD configs to include files > CryptoPkg: add CryptoServicePcd.hash_only.dsc.inc > CryptoPkg: add TPM hashes to CryptoServicePcd.min_dxe_smm.dsc.inc > OvmfPkg: add OvmfCrypto*.inc > OvmfPkg: OvmfPkgX64: use crypto includes > OvmfPkg: OvmfPkgIa32X64: use crypto includes > OvmfPkg: OvmfPkgIa32: use crypto includes > OvmfPkg: Microvm: use crypto includes > OvmfPkg: IntelTdx: use crypto includes > OvmfPkg: AmdSev: use crypto includes > This looks fine to me but I'll give other folks some time to chime in. Thanks, > .../Include/Dsc/CryptoServicePcd.all.dsc.inc | 29 +++++++ > .../Dsc/CryptoServicePcd.hash_only.dsc.inc | 8 ++ > .../Dsc/CryptoServicePcd.min_dxe_smm.dsc.inc | 37 +++++++++ > .../Dsc/CryptoServicePcd.min_pei.dsc.inc | 20 +++++ > .../Dsc/OvmfCryptoComponentsDxe.dsc.inc | 23 ++++++ > .../Dsc/OvmfCryptoComponentsPei.dsc.inc | 19 +++++ > .../Dsc/OvmfCryptoComponentsSmm.dsc.inc | 18 +++++ > OvmfPkg/Include/Dsc/OvmfCryptoDefines.dsc.inc | 5 ++ > OvmfPkg/Include/Dsc/OvmfCryptoLibs.dsc.inc | 57 ++++++++++++++ > CryptoPkg/CryptoPkg.dsc | 78 +------------------ > OvmfPkg/AmdSev/AmdSevX64.dsc | 12 ++- > OvmfPkg/IntelTdx/IntelTdxX64.dsc | 15 ++-- > OvmfPkg/Microvm/MicrovmX64.dsc | 24 +++--- > OvmfPkg/OvmfPkgIa32.dsc | 22 +++--- > OvmfPkg/OvmfPkgIa32X64.dsc | 22 +++--- > OvmfPkg/OvmfPkgX64.dsc | 22 +++--- > OvmfPkg/AmdSev/AmdSevX64.fdf | 6 ++ > OvmfPkg/IntelTdx/IntelTdxX64.fdf | 5 ++ > OvmfPkg/Microvm/MicrovmX64.fdf | 7 ++ > OvmfPkg/OvmfPkgIa32.fdf | 6 ++ > OvmfPkg/OvmfPkgIa32X64.fdf | 6 ++ > OvmfPkg/OvmfPkgX64.fdf | 6 ++ > OvmfPkg/Include/Fdf/OvmfCryptoDxeSmm.fdf.inc | 12 +++ > OvmfPkg/Include/Fdf/OvmfCryptoPei.fdf.inc | 9 +++ > 24 files changed, 331 insertions(+), 137 deletions(-) > create mode 100644 CryptoPkg/Include/Dsc/CryptoServicePcd.all.dsc.inc > create mode 100644 CryptoPkg/Include/Dsc/CryptoServicePcd.hash_only.dsc.inc > create mode 100644 CryptoPkg/Include/Dsc/CryptoServicePcd.min_dxe_smm.dsc.inc > create mode 100644 CryptoPkg/Include/Dsc/CryptoServicePcd.min_pei.dsc.inc > create mode 100644 OvmfPkg/Include/Dsc/OvmfCryptoComponentsDxe.dsc.inc > create mode 100644 OvmfPkg/Include/Dsc/OvmfCryptoComponentsPei.dsc.inc > create mode 100644 OvmfPkg/Include/Dsc/OvmfCryptoComponentsSmm.dsc.inc > create mode 100644 OvmfPkg/Include/Dsc/OvmfCryptoDefines.dsc.inc > create mode 100644 OvmfPkg/Include/Dsc/OvmfCryptoLibs.dsc.inc > create mode 100644 OvmfPkg/Include/Fdf/OvmfCryptoDxeSmm.fdf.inc > create mode 100644 OvmfPkg/Include/Fdf/OvmfCryptoPei.fdf.inc > > -- > 2.39.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#99909): https://edk2.groups.io/g/devel/message/99909 Mute This Topic: https://groups.io/mt/96850388/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
