I meant in the MdePkg/Include/IndustryStandard/IpmiKcs.h file
and the commit message in this patch that adds that file.
Mike
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang, Abner
> via groups.io
> Sent: Thursday, March 2, 2023 7:03 PM
> To: Kinney, Michael D <michael.d.kin...@intel.com>; devel@edk2.groups.io
> Cc: Gao, Liming <gaolim...@byosoft.com.cn>; Liu, Zhiguang
> <zhiguang....@intel.com>; Nickle Wang <nick...@nvidia.com>; Igor
> Kulchytskyy <ig...@ami.com>; Oram, Isaac W <isaac.w.o...@intel.com>; Attar,
> AbdulLateef (Abdul Lateef)
> <abdullateef.at...@amd.com>
> Subject: Re: [edk2-devel] [PATCH] MdePkg/Include: Add IPMI KCS definitions
>
> [AMD Official Use Only - General]
>
> Ok, that would be the patch set for edk2-platform I am going to send later,
> will update these two edk2 industry standard
> definition patches (KCS and MCTP) after edk2-platforms one.
>
> Thanks
> Abner
>
> > -----Original Message-----
> > From: Kinney, Michael D <michael.d.kin...@intel.com>
> > Sent: Friday, March 3, 2023 11:00 AM
> > To: Chang, Abner <abner.ch...@amd.com>; devel@edk2.groups.io
> > Cc: Gao, Liming <gaolim...@byosoft.com.cn>; Liu, Zhiguang
> > <zhiguang....@intel.com>; Nickle Wang <nick...@nvidia.com>; Igor
> > Kulchytskyy <ig...@ami.com>; Oram, Isaac W <isaac.w.o...@intel.com>;
> > Attar, AbdulLateef (Abdul Lateef) <abdullateef.at...@amd.com>; Kinney,
> > Michael D <michael.d.kin...@intel.com>
> > Subject: RE: [PATCH] MdePkg/Include: Add IPMI KCS definitions
> >
> > Caution: This message originated from an External Source. Use proper
> > caution when opening attachments, clicking links, or responding.
> >
> >
> > Hi Abner,
> >
> > Can you add a link/reference to the spec used in the INF and commit
> > message?
> >
> > Thanks,
> >
> > Mike
> >
> > > -----Original Message-----
> > > From: abner.ch...@amd.com <abner.ch...@amd.com>
> > > Sent: Thursday, March 2, 2023 6:32 PM
> > > To: devel@edk2.groups.io
> > > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming
> > > <gaolim...@byosoft.com.cn>; Liu, Zhiguang <zhiguang....@intel.com>;
> > > Nickle Wang <nick...@nvidia.com>; Igor Kulchytskyy <ig...@ami.com>;
> > > Oram, Isaac W <isaac.w.o...@intel.com>; Abdul Lateef Attar
> > > <abdullateef.at...@amd.com>
> > > Subject: [PATCH] MdePkg/Include: Add IPMI KCS definitions
> > >
> > > From: Abner Chang <abner.ch...@amd.com>
> > >
> > > BZ #4354
> > > This change adds definitions for IPMI KCS.
> > >
> > > Signed-off-by: Abner Chang <abner.ch...@amd.com>
> > > Cc: Michael D Kinney <michael.d.kin...@intel.com>
> > > Cc: Liming Gao <gaolim...@byosoft.com.cn>
> > > Cc: Zhiguang Liu <zhiguang....@intel.com>
> > > Cc: Nickle Wang <nick...@nvidia.com>
> > > Cc: Igor Kulchytskyy <ig...@ami.com>
> > > Cc: Isaac Oram <isaac.w.o...@intel.com>
> > > Cc: Abdul Lateef Attar <abdullateef.at...@amd.com>
> > > ---
> > > MdePkg/MdePkg.dec | 5 ++
> > > MdePkg/Include/IndustryStandard/IpmiKcs.h | 72
> > > +++++++++++++++++++++++
> > > 2 files changed, 77 insertions(+)
> > > create mode 100644 MdePkg/Include/IndustryStandard/IpmiKcs.h
> > >
> > > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index
> > > 3d08f20d15b..0ed033983bf 100644
> > > --- a/MdePkg/MdePkg.dec
> > > +++ b/MdePkg/MdePkg.dec
> > > @@ -9,6 +9,7 @@
> > > # (C) Copyright 2016 - 2021 Hewlett Packard Enterprise Development
> > > LP<BR> # Copyright (c) 2022, Loongson Technology Corporation Limited.
> > > All rights reserved.<BR> # Copyright (c) 2021 - 2022, Arm Limited.
> > > All rights reserved.<BR>
> > > +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
> > > +reserved.<BR>
> > > #
> > > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -2332,6 +2333,10
> > > @@
> > > # @Prompt Memory Address of GuidedExtractHandler Table.
> > >
> > >
> > gEfiMdePkgTokenSpaceGuid.PcdGuidedExtractHandlerTableAddress|0x1000
> > 000
> > > |UINT64|0x30001015
> > >
> > > + ## This value is the IPMI KCS Interface I/O base address used to
> > > transmit
> > IPMI commands.
> > > + # @Prompt IPMI KCS Interface I/O Base Address
> > > +
> > > +
> > gEfiMdePkgTokenSpaceGuid.PcdIpmiKcsBaseAddress|0xca2|UINT16|0x0000
> > 00
> > > + 31
> > > +
> > > [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
> > > ## This value is used to set the base address of PCI express hierarchy.
> > > # @Prompt PCI Express Base Address.
> > > diff --git a/MdePkg/Include/IndustryStandard/IpmiKcs.h
> > > b/MdePkg/Include/IndustryStandard/IpmiKcs.h
> > > new file mode 100644
> > > index 00000000000..2a51698b126
> > > --- /dev/null
> > > +++ b/MdePkg/Include/IndustryStandard/IpmiKcs.h
> > > @@ -0,0 +1,72 @@
> > > +/** @file
> > > + IPMI KCS Register Definitions
> > > +
> > > + Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
> > > +reserved.<BR>
> > > + SPDX-License-Identifier: BSD-2-Clause-Patent **/
> > > +
> > > +#ifndef IPMI_KCS_H_
> > > +#define IPMI_KCS_H_
> > > +
> > > +#define IPMI_KCS_STATUS_REGISTER_OFFSET 1
> > > +#define IPMI_KCS_COMMAND_REGISTER_OFFSET 1
> > > +#define IPMI_KCS_DATA_OUT_REGISTER_OFFSET 0
> > > +#define IPMI_KCS_DATA_IN_REGISTER_OFFSET 0
> > > +
> > > +///
> > > +/// IPMI KCS Interface Status Bits
> > > +///
> > > +#define IPMI_KCS_OBF BIT0
> > > +#define IPMI_KCS_IBF BIT1
> > > +#define IPMI_KCS_SMS_ATN BIT2
> > > +#define IPMI_KCS_COMMAND_DATA BIT3
> > > +#define IPMI_KCS_OEM1 BIT4
> > > +#define IPMI_KCS_OEM2 BIT5
> > > +#define IPMI_KCS_S0 BIT6
> > > +#define IPMI_KCS_S1 BIT7
> > > +
> > > +///
> > > +/// IPMI KCS Interface Control Codes
> > > +///
> > > +#define IPMI_KCS_CONTROL_CODE_GET_STATUS_ABORT 0x60
> > > +#define IPMI_KCS_CONTROL_CODE_WRITE_START 0x61
> > > +#define IPMI_KCS_CONTROL_CODE_WRITE_END 0x62
> > > +#define IPMI_KCS_CONTROL_CODE_READ 0x68
> > > +
> > > +///
> > > +/// Status Codes
> > > +///
> > > +#define IPMI_KCS_STATUS_NO_ERROR 0x00
> > > +#define IPMI_KCS_STATUS_ABORT 0x01
> > > +#define IPMI_KCS_STATUS_ILLEGAL 0x02
> > > +#define IPMI_KCS_STATUS_LENGTH_ERROR 0x06
> > > +#define IPMI_KCS_STATUS_UNSPECIFIED 0xFF
> > > +
> > > +///
> > > +/// KCS Interface State Bit
> > > +///
> > > +typedef enum {
> > > + IPMI_KCS_IDLE_STATE = 0,
> > > + IPMI_KCS_READ_STATE,
> > > + IPMI_KCS_WRITE_STATE,
> > > + IPMI_KCS_ERROR_STATE
> > > +} IPMI_KCS_STATE;
> > > +
> > > +///
> > > +/// IPMI KCS Interface Request Format /// typedef struct {
> > > + UINT8 NetFunc;
> > > + UINT8 Command;
> > > + UINT8 Data[0];
> > > +} IPMI_KCS_RESQUEST_HEADER;
> > > +
> > > +///
> > > +/// IPMI KCS Interface Response Format /// typedef struct {
> > > + UINT8 NetFunc;
> > > + UINT8 Command;
> > > + UINT8 CompletionCode;
> > > +} IPMI_KCS_RESPONSE_HEADER;
> > > +#endif
> > > --
> > > 2.37.1.windows.1
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100655): https://edk2.groups.io/g/devel/message/100655
Mute This Topic: https://groups.io/mt/97354433/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
