On Thu, Mar 02, 2023 at 03:49:17PM -0600, Andrei Warkentin wrote:
> Hello!
>
> Here are three patches that provide a SerialLib backed by SBI console. Both
> legacy and DBCN mechanisms
> are supported in various execution environments and have been tested (with
> UART and HTIF).
>
> This is also available at
> https://github.com/andreiw/edk2-rv-wip/tree/patchset-2
>
Hi Andrei,
Here are some quick comments.
1) Please run python BaseTools/Scripts/SetupGit.py -n edk2 in your clone
always.
2) Please run BaseTools/Scripts/PatchCheck.py on each patch/commit and
fix the errors.
for ex: I see many CRLF errors
* Line ending ('\n') is not CRLF
File: OvmfPkg/RiscVVirt/Sec/SecMain.c
3)Since these are new INF files, it should have INF_VERSION as 1.27
(0x0001001B)
https://tianocore-docs.github.io/edk2-InfSpecification/release-1.27/2_inf_overview/24_[defines]_section.html#24-defines-section
4) GUID should be unique for different libraries.
5) MODULE_TYPE should not be BASE but something like SEC|PEI. BASE will
include DXE also. Similarly, DXE library should exclude SEC/PEI.
6) Legacy extensions can be deprecated. So, I think it is
better to probe both DBCN and legacy extension and then only use it.
Will review in detail some time next week.
Thanks,
Sunil
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100661): https://edk2.groups.io/g/devel/message/100661
Mute This Topic: https://groups.io/mt/97349678/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
