Reviewed-by: Isaac Oram <isaac.w.o...@intel.com>
-----Original Message-----
From: Mike Maslenkin <mike.maslen...@gmail.com>
Sent: Monday, February 27, 2023 3:28 PM
To: devel@edk2.groups.io
Cc: Mike Maslenkin <mike.maslen...@gmail.com>; Oram, Isaac W
<isaac.w.o...@intel.com>; Desimone, Nathaniel L
<nathaniel.l.desim...@intel.com>; Gao, Liming <gaolim...@byosoft.com.cn>
Subject: [PATCH edk2-platforms 1/3] IpmiFeaturePkg: fix IPMI GetSelfTest
command response parsing
Byte 0 of a response contains completion code for the command.
So, the examined data starts from byte 1. It's easy to make a mistake here
since specification counts response data from 1.
For the "Get Self Test Results" command Intelligent Platform Management
Interface Specification v2.0 rev 1.1 paragraph 20.4 defines response as:
+-----+---------------------------------------------------------------+
|byte | data field |
+-----+---------------------------------------------------------------+
| 1 | Completion Code |
| | |
| 2 | 55h = No error. All Self Tests Passed. |
| | 56h = Self Test function not implemented in this controller. |
| | 57h = Corrupted or inaccessible data or devices |
| | 58h = Fatal hardware error |
| | |
| 3 | For byte 2 = 55h, 56h, FFh: 00h |
| | For byte 2 = 58h, all other: Device-specific |
| | For byte 2 = 57h: self-test error bitfield. |
+-----+---------------------------------------------------------------+
Signed-off-by: Mike Maslenkin <mike.maslen...@gmail.com>
---
.../IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c
b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c
index d788b4886723..aeaefaad642e 100644
---
a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/
+++ IpmiInit.c
@@ -161,7 +161,7 @@ Returns:
// Check the IPMI defined self test results. // Additional Cases are
device specific test results. //- switch (IpmiInstance->TempData[0]) {+
switch (IpmiInstance->TempData[1]) { case IPMI_APP_SELFTEST_NO_ERROR:
case IPMI_APP_SELFTEST_NOT_IMPLEMENTED: IpmiInstance->BmcStatus =
BMC_OK;@@ -173,7 +173,7 @@ Returns:
// BootBlock Firmware corruption, and Operational Firmware Corruption.
All // other errors are BMC soft failures. //- if
((IpmiInstance->TempData[1] & (IPMI_APP_SELFTEST_FRU_CORRUPT |
IPMI_APP_SELFTEST_FW_BOOTBLOCK_CORRUPT | IPMI_APP_SELFTEST_FW_CORRUPT)) != 0)
{+ if ((IpmiInstance->TempData[2] & (IPMI_APP_SELFTEST_FRU_CORRUPT |
IPMI_APP_SELFTEST_FW_BOOTBLOCK_CORRUPT | IPMI_APP_SELFTEST_FW_CORRUPT)) != 0) {
IpmiInstance->BmcStatus = BMC_HARDFAIL; } else {
IpmiInstance->BmcStatus = BMC_SOFTFAIL;@@ -181,7 +181,7 @@ Returns:
// // Check if SDR repository is empty and report it if it is.
//- if ((IpmiInstance->TempData[1] &
IPMI_APP_SELFTEST_SDR_REPOSITORY_EMPTY) != 0) {+ if
((IpmiInstance->TempData[2] & IPMI_APP_SELFTEST_SDR_REPOSITORY_EMPTY) != 0) {
if (*ErrorCount < MAX_SOFT_COUNT) {
StatusCodeValue[*ErrorCount] = EFI_COMPUTING_UNIT_FIRMWARE_PROCESSOR |
CU_FP_EC_SDR_EMPTY; (*ErrorCount)++;--
2.35.3
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100814): https://edk2.groups.io/g/devel/message/100814
Mute This Topic: https://groups.io/mt/97279448/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
