Hello Rebecc, Thanks for working on this - the toolchain definitions are not the most fun part of the project.
On Wed, 22 Mar 2023 at 02:30, Rebecca Cran <rebe...@bsdio.com> wrote: > > Update the toolchain definitions: > > - Delete the CLANG35 and CLANG38 toolchains, and replace CLANG38 with > CLANGDWARF, updating it to support ARM and AARCH64 in addition to X64 > and IA32. > > - Remove VS2008, VS2010, VS2012 and VS2013. > > - Remove EBC compiler definitions. Full removal of EBC support from the > various packages etc. will be done in a follow-up patch series. > > - Remove unused IPHONE_TOOLS and SOURCERY_CYGWIN_TOOLS definitions. > Please add some motivation as to *why* these changes improve upon the current situation. Removing stuff is generally a good thing, but it makes a difference whether keeping it is problematic or it whether is just janitorial work. > Personal GitHub PR: https://github.com/tianocore/edk2/pull/4158 > GitHub branch: https://github.com/bcran/edk2/tree/clangdwarf > > Rebecca Cran (9): > OvmfPkg: Replace static struct initialization with ZeroMem call > CryptoPkg: Add CLANGDWARF and remove CLANG35 and CLANG38 compiler > flags > BaseTools: Update CLANGDWARF toolchain and remove CLANG35 and CLANG38 > BaseTools: Remove VS2008, 2010, 2012 and 2013 toolchain definitions > BaseTools: Remove VS2008-VS2013 remnants > MdePkg: Remove VS2008-VS2013 remnants > edksetup.bat: Remove VS2008-VS2013 remnants > BaseTools: Remove unused IPHONE_TOOLS and SOURCERY_CYGWIN_TOOLS defs > BaseTools: Remove EBC (EFI Byte Code) compiler definitions > > CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf | 3 +- > CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 3 +- > CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 3 +- > CryptoPkg/Library/BaseCryptLib/SecCryptLib.inf | 3 +- > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 3 +- > CryptoPkg/Library/BaseCryptLib/UnitTestHostBaseCryptLib.inf | 3 +- > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 3 +- > CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf | 3 +- > CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 3 +- > CryptoPkg/Library/OpensslLib/OpensslLibFull.inf | 3 +- > CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf | 3 +- > MdePkg/Include/Ia32/ProcessorBind.h | 8 +- > MdePkg/Include/X64/ProcessorBind.h | 8 +- > OvmfPkg/Library/PlatformInitLib/MemDetect.c | 4 +- > BaseTools/Conf/tools_def.template | 1572 > +++----------------- > BaseTools/Scripts/SetVisualStudio.bat | 22 +- > BaseTools/Scripts/ShowEnvironment.bat | 44 - > BaseTools/get_vsvars.bat | 13 - > BaseTools/set_vsprefix_envs.bat | 64 - > BaseTools/toolsetup.bat | 24 +- > edksetup.bat | 6 +- > 21 files changed, 192 insertions(+), 1606 deletions(-) > > -- > 2.34.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101568): https://edk2.groups.io/g/devel/message/101568 Mute This Topic: https://groups.io/mt/97769541/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-