Hi Gua, Thanks for the review. Do you have a proposal or small example on how you want to separate into another FV?
Thanks, Sheng On Wed, 26 Apr 2023 at 14:55, Guo, Gua <gua....@intel.com> wrote: > Do we separate these Security Driver into separate FV ? > > > > I really don’t want to see gather everything into uefi_fv. > > Separate it into a lot of fv, we can easy to plug in and plug out. > > > > Thanks, > > Gua > > > > *From:* devel@edk2.groups.io <devel@edk2.groups.io> * On Behalf Of *Sean > Rhodes > *Sent:* Wednesday, April 26, 2023 8:33 PM > *To:* Benjamin Doron <benjamin.doro...@gmail.com> > *Cc:* devel@edk2.groups.io; Dong, Guo <guo.d...@intel.com>; Ni, Ray < > ray...@intel.com>; Lu, James <james...@intel.com>; Guo, Gua < > gua....@intel.com> > *Subject:* Re: [edk2-devel][PATCH v1 2/2] UefiPayloadPkg: Enable RNG > support > > > > Reviewed-by: Sean Rhodes <sean@starlabs.systems> > > > > On Tue, 25 Apr 2023 at 18:09, Benjamin Doron <benjamin.doro...@gmail.com> > wrote: > > From: Benjamin Doron <benjamin.do...@9elements.com> > > Uses CPU RDRAND support and installs the EfiRngProtocol. > The protocol may be used by iPXE or the Linux kernel to gather entropy. > > Cc: Guo Dong <guo.d...@intel.com> > Cc: Ray Ni <ray...@intel.com> > Cc: Sean Rhodes <sean@starlabs.systems> > Cc: James Lu <james...@intel.com> > Cc: Gua Guo <gua....@intel.com> > Signed-off-by: Benjamin Doron <benjamin.do...@9elements.com> > --- > UefiPayloadPkg/UefiPayloadPkg.dsc | 3 +++ > UefiPayloadPkg/UefiPayloadPkg.fdf | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc > b/UefiPayloadPkg/UefiPayloadPkg.dsc > index 1e803ba01567..486af2396731 100644 > --- a/UefiPayloadPkg/UefiPayloadPkg.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc > @@ -634,6 +634,9 @@ > MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf > !endif > UefiCpuPkg/CpuDxe/CpuDxe.inf > +!if $(CPU_RNG_ENABLE) == TRUE > + SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.inf > +!endif > MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > !if $(BOOTSPLASH_IMAGE) > MdeModulePkg/Logo/LogoDxe.inf > diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf > b/UefiPayloadPkg/UefiPayloadPkg.fdf > index f8c2aa8c4a02..53add65a6a40 100644 > --- a/UefiPayloadPkg/UefiPayloadPkg.fdf > +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf > @@ -157,6 +157,9 @@ INF CryptoPkg/Driver/CryptoDxe.inf > INF MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf > !endif > INF UefiCpuPkg/CpuDxe/CpuDxe.inf > +!if $(CPU_RNG_ENABLE) == TRUE > +INF SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.inf > +!endif > > INF RuleOverride = UI MdeModulePkg/Application/UiApp/UiApp.inf > INF MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuApp.inf > -- > 2.39.2 > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103649): https://edk2.groups.io/g/devel/message/103649 Mute This Topic: https://groups.io/mt/98497422/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
