[AMD Official Use Only - General] Hi Tinh, Thanks for this effort. I have no problem with this patch set but you still have to get R-B from maintainers. Two feedbacks here, - Please put BZ # in commit message in the patch 1/3-3/3. Ex: BZ#: 4434 - Add IPMI SSIF definitions - As the feedback I gave to patch 1/3. I think we better have maintainers Cc in the commit message.
Thanks Abner > -----Original Message----- > From: Tinh Nguyen <tinhngu...@os.amperecomputing.com> > Sent: Wednesday, May 3, 2023 1:40 AM > To: devel@edk2.groups.io > Cc: patc...@amperecomputing.com; michael.d.kin...@intel.com; > gaolim...@byosoft.com.cn; zhiguang....@intel.com; Chang, Abner > <abner.ch...@amd.com>; Tinh Nguyen > <tinhngu...@os.amperecomputing.com> > Subject: [PATCH v2 0/3] Add IPMI SSIF definitions > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > Change from v1: > - Separate the commit for the IPMI SSIF header and IPMI SSIF PCDs > - Correct some indent and comment style. > - Change the PCDs name for a more readable. > - Support KCS/SMIC Interface Capabilities too. > > Tinh Nguyen (3): > MdePkg/IndustryStandard: Add definitions for IPMI SSIF > MdePkg: Add new PCDs for IPMI SSIF > MdePkg/IndustryStandard: Add Interface Capabilities definitions > > MdePkg/MdePkg.dec | 26 ++++++ > MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 46 +++++++++ > MdePkg/Include/IndustryStandard/IpmiSsif.h | 98 > ++++++++++++++++++++ > 3 files changed, 170 insertions(+) > create mode 100644 MdePkg/Include/IndustryStandard/IpmiSsif.h > > -- > 2.40.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103873): https://edk2.groups.io/g/devel/message/103873 Mute This Topic: https://groups.io/mt/98644351/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
