On 5/10/23 06:10, Ard Biesheuvel wrote:
On Wed, 10 May 2023 at 14:09, Rebecca Cran <rebe...@bsdio.com> wrote:
On 5/10/23 05:03, Ard Biesheuvel wrote:
On Wed, 10 May 2023 at 01:53, Rebecca Cran <rebe...@bsdio.com> wrote:
Set the OBJCOPY path for the CLANGDWARF toolchain to 'llvm-objcopy' to
override the default of 'echo'.

Signed-off-by: Rebecca Cran <rebe...@bsdio.com>
This appears to break the AArch64 CLANGDWARF build.

https://ci.linaro.org/job/leg-virt-tianocore-edk2-upstream/4880/console
Ugh, I'm sorry. We're not overriding the OBJCOPY_FLAGS for ARM and
AARCH64, so it uses the default of "not needed for" which previously got
echoed.

I'll work on a better local testing process to avoid such an obvious
breakage in future.


Would you like this commit reverted, or should I submit a patch to fix it?

No revert necessary - it should be a minimal fix, and we can just
apply it on top.

Thanks. I've just sent out a fix: "BaseTools: Revert Set the CLANGDWARF OBJCOPY path in tools_def.template"

I was attempting to match what gcc does in terms of objcopy, but we can leave OBJCOPY as echo and just have RC set to llvm-objcopy.


--
Rebecca Cran



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104547): https://edk2.groups.io/g/devel/message/104547
Mute This Topic: https://groups.io/mt/98796313/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to