On Wed, 10 May 2023 at 15:54, Ard Biesheuvel <a...@kernel.org> wrote: > > On Wed, 10 May 2023 at 11:18, Ard Biesheuvel <a...@kernel.org> wrote: > > > > On Wed, 10 May 2023 at 09:39, Ard Biesheuvel <a...@kernel.org> wrote: > > > > > > On Wed, 10 May 2023 at 09:34, Gerd Hoffmann <kra...@redhat.com> wrote: > > > > > > > > EventNames is used to pretty-print debug log messages. > > > > Add #ifdef to only include it in debug builds. > > > > Fixes a clang build failure. > > > > > > > > Reported-by: Rebecca Cran <rebe...@bsdio.com> > > > > Signed-off-by: Gerd Hoffmann <kra...@redhat.com> > > > > > > Queued up as #4381 - thanks. > > > > > > > This appears to break the build > > > > https://github.com/tianocore/edk2/pull/4381 > > Actually, looking at the code, I think the Clang diagnostic is highly > dubious here. The non-DEBUG code takes the ARRAY_SIZE() of EventNames, > and so the #ifdef will result in a compiler error. > > I suppose we can work around this, but we might also just add > -Wunneeded-internal-declaration to the clang cflags for RELEASE
I've sent a BaseTools patch for this - I suggest we merge that and drop this one. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#104570): https://edk2.groups.io/g/devel/message/104570 Mute This Topic: https://groups.io/mt/98801293/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
