> +  //
> +  // Check cpu runs in 64bit long mode or 32bit protected mode.
1. this comment seems to be redundant.

> +  //
> +  if (sizeof (UINTN) == sizeof (UINT64)) {
> +    //
> +    // If cpu has already runned in 64bit long mode PEI, Page table Level in 
> DXE
> must align with previous level.
2. runned -> run

> +    //
> +    Cr4.UintN         = AsmReadCr4 ();
> +    Page5LevelSupport = Cr4.Bits.LA57 ? TRUE : FALSE;

3. "Cr4.Bits.LA57 != 0"

> +    ASSERT (PcdGetBool (PcdUse5LevelPageTable) == Page5LevelSupport);

4. Good check!




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104768): https://edk2.groups.io/g/devel/message/104768
Mute This Topic: https://groups.io/mt/98843222/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: 
https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to