On Mon, May 15, 2023 at 4:20 PM Marvin Häuser <[email protected]> wrote: > > Well, I explicitly added this macro as a prerequisite to code used in our new > PE library (remember this patch was initially sent in 2021). We still require > it downstream, but obviously upstream is not interested in the related > contributions that were to follow at the time. > > Gerd picked it up because he wanted to attempt to re-try contributing the new > PE library, but I haven't heard from him in weeks. > > Design-wise, I agree it could be removed again. However, there first was a > downstream burden when adding it (as we needed to rewrite our history to drop > our downstream patch in favour of the upstream solution). Now introducing > another downstream burden *again* to remove the macro that was added only a > few weeks back would be a sign of poor management and planning.
I don't agree with the removal of the macro. It's useful enough to consumers of Base.h, and clearly there's code that is indeed actively using it. It's also a single line of code. -- Pedro -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#104888): https://edk2.groups.io/g/devel/message/104888 Mute This Topic: https://groups.io/mt/98904940/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
