Pushed as acf260597a..15f27d5c30 -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Isaac Oram Sent: Monday, May 15, 2023 2:22 PM To: devel@edk2.groups.io; rebe...@bsdio.com; Dong, Eric <eric.d...@intel.com>; Gao, Liming <gaolim...@byosoft.com.cn>; Chaganty, Rangasai V <rangasai.v.chaga...@intel.com>; Desimone, Nathaniel L <nathaniel.l.desim...@intel.com> Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/Intel: Fix type mismatches from prototypes in BoardBdsHookLib.c
Reviewed-by: Isaac Oram <isaac.w.o...@intel.com> -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran Sent: Sunday, May 14, 2023 10:54 PM To: devel@edk2.groups.io; Dong, Eric <eric.d...@intel.com>; Oram, Isaac W <isaac.w.o...@intel.com>; Gao, Liming <gaolim...@byosoft.com.cn>; Chaganty, Rangasai V <rangasai.v.chaga...@intel.com>; Desimone, Nathaniel L <nathaniel.l.desim...@intel.com> Cc: Rebecca Cran <rebe...@bsdio.com> Subject: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/Intel: Fix type mismatches from prototypes in BoardBdsHookLib.c Add EFIAPI to the implementations of: BdsBeforeConsoleAfterTrustedConsoleCallback BdsBeforeConsoleBeforeEndOfDxeGuidCallback BdsAfterConsoleReadyBeforeBootOptionCallback This makes them match the prototypes, and avoids an -Wlto-type-mismatch warning. Signed-off-by: Rebecca Cran <rebe...@bsdio.com> --- Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c b/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c index e866f70bc336..bc80badb3e01 100644 --- a/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c +++ b/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHook +++ Lib.c @@ -1273,6 +1273,7 @@ BdsReadyToBootCallback ( @param[in] Context Pointer to the context data registered to the Event. **/ VOID +EFIAPI BdsBeforeConsoleAfterTrustedConsoleCallback ( IN EFI_EVENT Event, IN VOID *Context @@ -1294,6 +1295,7 @@ BdsBeforeConsoleAfterTrustedConsoleCallback ( @param[in] Context Pointer to the context data registered to the Event. **/ VOID +EFIAPI BdsBeforeConsoleBeforeEndOfDxeGuidCallback ( IN EFI_EVENT Event, IN VOID *Context @@ -1311,6 +1313,7 @@ BdsBeforeConsoleBeforeEndOfDxeGuidCallback ( @param[in] Context Pointer to the context data registered to the Event. **/ VOID +EFIAPI BdsAfterConsoleReadyBeforeBootOptionCallback ( IN EFI_EVENT Event, IN VOID *Context -- 2.39.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#104955): https://edk2.groups.io/g/devel/message/104955 Mute This Topic: https://groups.io/mt/98897921/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
