Thank for the review, will update v4 to take care it. -----Original Message----- From: Ni, Ray <ray...@intel.com> Sent: Wednesday, May 24, 2023 4:14 PM To: devel@edk2.groups.io; Guo, Gua <gua....@intel.com> Cc: Kinney, Michael D <michael.d.kin...@intel.com> Subject: RE: [edk2-devel] [PATCH v2 1/1] PcAtChipsetPkg: RTC Runtime unable to get correct IO port by PCD
> > -extern UINTN mRtcIndexRegister; > > -extern UINTN mRtcTargetRegister; > > - > > +extern UINTN mRtcIndexRegister; > > +extern UINTN mRtcTargetRegister; > > +extern UINTN mRtcIndexRegisterIo; > > +extern UINTN mRtcTargetRegisterIo; Can you avoid adding the mRtcIndexRegisterIo/ mRtcTargetRegisterIo? Can you just use the old variables mRtcIndexRegister/ mRtcTargetRegister. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105218): https://edk2.groups.io/g/devel/message/105218 Mute This Topic: https://groups.io/mt/99063019/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
