On Thu, 1 Jun 2023 at 19:28, Pedro Falcato <[email protected]> wrote: > > This patch-set replaces the OVMF specific SataControllerDxe with the > MdeModulePkg/Bus/Pci one. > They were both forked from the same code, and are code-and-functionality > similar. As such, there > seems to be no need for duplication here. > > The first four pages both replay OvmfPkg/SataControllerDxe commits and fix up > a couple of details. > The rest of the patches (minus the last) replace OvmfPkg/SataControllerDxe > with the MdeModulePkg variant. > The last patch, finally, removes the thing. > > Tested by booting in QEMU (Q35 (AHCI) and PC (IDE)). > More testing from other, alternative platforms is desired, although breakage > seems unlikely. > > This patchset (or at least, the last patch) depends on the edk2-platforms > patch series to get merged. > > (+CC Laszlo as the author of the original SataControllerDxe patches) > > PR: https://github.com/tianocore/edk2/pull/4370 > > Cc: Ard Biesheuvel <[email protected]> > Cc: Jiewen Yao <[email protected]> > Cc :Jordan Justen <[email protected]> > Cc: Gerd Hoffmann <[email protected]> > Cc: Erdem Aktas <[email protected]> > Cc: James Bottomley <[email protected]> > Cc: Min Xu <[email protected]> > Cc: Tom Lendacky <[email protected]> > Cc: Michael Roth <[email protected]> > Cc: Rebecca Cran <[email protected]> > Cc: Peter Grehan <[email protected]> > Cc: Corvin Köhne <[email protected]> > Cc: Sebastien Boeuf <[email protected]> > Cc: Anthony Perard <[email protected]> > Cc: Julien Grall <[email protected]> > Cc: Laszlo Ersek <[email protected]> > > Changes: > v3: > - Pick up Reviewed-by and Acked-by tags > v2: > - Address Laszlo's feedback wrt commit to port into MdeModulePkg > - Address Laszlo's feedback wrt how to split the removal of the driver and > the patches for each sub-platform maintainer > - Address Mike Maslenkin's feedback on the preexisting ASSERTs (Private != > NULL) > - Add Gerd's ACK and Tested-by (conservatively) to patches 6 and 12 (since > they are remotely QEMU related) > > Pedro Falcato (12): > MdeModulePkg/SataControllerDxe: Clean up error handling in Start() > MdeModulePkg/SataControllerDxe: Log expected errors at DEBUG_INFO > level > MdeModulePkg/SataControllerDxe: Remove useless null check > MdeModulePkg/SataControllerDxe: Fix up ASSERTS (Private != NULL) > OvmfPkg: Replace the OVMF-specific SataControllerDxe > OvmfPkg/Microvm: Replace the OVMF-specific SataControllerDxe > OvmfPkg/Bhyve: Replace the OVMF-specific SataControllerDxe > OvmfPkg/CloudHv: Replace the OVMF-specific SataControllerDxe > OvmfPkg/IntelTdx: Replace the OVMF-specific SataControllerDxe > OvmfPkg/AmdSev: Replace the OVMF-specific SataControllerDxe > OvmfPkg/Xen: Replace the OVMF-specific SataControllerDxe > OvmfPkg: Remove SataControllerDxe >
Merged as #4466 Thanks! -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105597): https://edk2.groups.io/g/devel/message/105597 Mute This Topic: https://groups.io/mt/99269907/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
