Sorry for the late response, inline comments below:
> -----Original Message-----
> From: brit.ches...@amd.com <brit.ches...@amd.com>
> Sent: Wednesday, May 17, 2023 6:16 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.w...@intel.com>; Gao, Liming
> <gaolim...@byosoft.com.cn>; Wu, Hao A <hao.a...@intel.com>; Ni, Ray
> <ray...@intel.com>
> Subject: [PATCH v1 1/1] MdeModulePkg: UsbBusDxe: Build Descriptor table
> after resetting port
>
> From: Britton Chesley <brit.ches...@amd.com>
>
> Fixed a bug which led to an ASSERT due to the USB device context being
> maintained after a port reset, but the underlying XHCI context was
> uninitialized. Added build descriptor table call in UsbIoPortReset
Could you help to elaborate on what data in XHCI is not initialized that leads
to the assert? Thanks.
>
> Cc: Jian J Wang <jian.j.w...@intel.com>
> Cc: Liming Gao <gaolim...@byosoft.com.cn>
> Cc: Hao A Wu <hao.a...@intel.com>
> Cc: Ray Ni <ray...@intel.com>
> Signed-off-by: Britton Chesley <brit.ches...@amd.com>
> ---
> MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c
> b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c
> index c25f3cc2f279..55e0e1f16cdb 100644
> --- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c
> +++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c
> @@ -882,6 +882,12 @@ UsbIoPortReset (
> // is in CONFIGURED state.
> //
> if (Dev->ActiveConfig != NULL) {
> + Status = UsbBuildDescTable (Dev);
The UsbBuildDescTable function will allocate new buffer resources for and under
Dev->DevDesc (device, configuration and interface descriptors).
Could you help to double check if the old buffers are properly freed for the
proposed change?
Best Regards,
Hao Wu
> +
> + if (EFI_ERROR (Status)) {
> + DEBUG ((DEBUG_ERROR, "UsbIoPortReset: failed to build descriptor
> table - %r\n", Status));
> + }
> +
> Status = UsbSetConfig (Dev, Dev->ActiveConfig-
> >Desc.ConfigurationValue);
>
> if (EFI_ERROR (Status)) {
> --
> 2.36.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#105754): https://edk2.groups.io/g/devel/message/105754
Mute This Topic: https://groups.io/mt/98948709/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
