Reviewed-by: Ashraf Ali S <[email protected]> -----Original Message----- From: Aishwarya, KurugoduMelmatamX <[email protected]> Sent: Friday, June 9, 2023 7:10 PM To: [email protected] Cc: Aishwarya, KurugoduMelmatamX <[email protected]>; Chiu, Chasel <[email protected]>; Desimone, Nathaniel L <[email protected]>; Duggapu, Chinni B <[email protected]>; Chen, Gang C <[email protected]>; Zeng, Star <[email protected]>; Kuo, Ted <[email protected]>; S, Ashraf Ali <[email protected]>; Mohapatra, Susovan <[email protected]> Subject: [PATCH] Get HobListPtr before calling the Multiphase FSPS
REF : https://bugzilla.tianocore.org/show_bug.cgi?id=4480 In the FspsWrapperPeim, before calling FspWrapperVariableRequestHandler and FspWrapperMultiPhaseHandler ,FspHobListPtr should be available so that BL will be able to get the correct FspHobListPtr value Signed-off-by: kurugodx <[email protected]> Cc: Chasel Chiu <[email protected]> Cc: Nate DeSimone <[email protected]> Cc: Duggapu Chinni B <[email protected]> Cc: Chen Gang C <[email protected]> Cc: Star Zeng <[email protected]> Cc: Ted Kuo <[email protected]> Cc: Ashraf Ali S <[email protected]> Cc: Susovan Mohapatra <[email protected]> --- .../FspsWrapperPeim/FspsWrapperPeim.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c index 08fe0fdb7e..1d4dd60577 100644 --- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c +++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c @@ -336,6 +336,14 @@ PeiMemoryDiscoveredNotify ( DEBUG ((DEBUG_INFO, "FspSiliconInit status: %r\n", Status)); + // + // Get FspHobList + // + GuidHob = GetFirstGuidHob (&gFspHobGuid); ASSERT (GuidHob != NULL); + FspHobListPtr = *(VOID **)GET_GUID_HOB_DATA (GuidHob); DEBUG + ((DEBUG_INFO, "FspHobListPtr - 0x%x\n", FspHobListPtr)); + if (Status == FSP_STATUS_VARIABLE_REQUEST) { // // call to Variable request handler @@ -356,13 +364,6 @@ PeiMemoryDiscoveredNotify ( DEBUG ((DEBUG_ERROR, "ERROR - TestFspSiliconInitApiOutput () fail, Status = %r\n", Status)); } - // - // Now FspHobList complete, process it - // - GuidHob = GetFirstGuidHob (&gFspHobGuid); - ASSERT (GuidHob != NULL); - FspHobListPtr = *(VOID **)GET_GUID_HOB_DATA (GuidHob); - DEBUG ((DEBUG_INFO, "FspHobListPtr - 0x%x\n", FspHobListPtr)); PostFspsHobProcess (FspHobListPtr); // -- 2.41.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105972): https://edk2.groups.io/g/devel/message/105972 Mute This Topic: https://groups.io/mt/99428705/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
