SiliconPkg can build the hob so have the HOB interface is enough. Platform can use TraceHubLib to consume the HOB. ________________________________ From: Ni, Ray <[email protected]> Sent: Wednesday, June 21, 2023 9:25:08 PM To: Guo, Gua <[email protected]>; [email protected] <[email protected]>; Hsu, VictorX <[email protected]> Cc: Gao, Liming <[email protected]>; Chan Laura <[email protected]>; Prakashan, Krishnadas Veliyathuparambil <[email protected]>; K N, Karthik <[email protected]> Subject: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg
I don’t think that’s the solution to resolve pkg dependencies by adding interfaces to mdePkg. From: Guo, Gua <[email protected]> Sent: Wednesday, June 21, 2023 9:23 PM To: Ni, Ray <[email protected]>; [email protected]; Hsu, VictorX <[email protected]> Cc: Gao, Liming <[email protected]>; Chan Laura <[email protected]>; Prakashan, Krishnadas Veliyathuparambil <[email protected]>; K N, Karthik <[email protected]> Subject: Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Based on Green H, we need to let the HOB can be consumed by SiliconPkg so move it from MdeModulePkg to MdePkg. ________________________________ From: Ni, Ray <[email protected]<mailto:[email protected]>> Sent: Wednesday, June 21, 2023 9:20:23 PM To: [email protected]<mailto:[email protected]> <[email protected]<mailto:[email protected]>>; Guo, Gua <[email protected]<mailto:[email protected]>>; Hsu, VictorX <[email protected]<mailto:[email protected]>> Cc: Gao, Liming <[email protected]<mailto:[email protected]>>; Chan Laura <[email protected]<mailto:[email protected]>>; Prakashan, Krishnadas Veliyathuparambil <[email protected]<mailto:[email protected]>>; K N, Karthik <[email protected]<mailto:[email protected]>> Subject: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Why is this GUID moved to MdePkg? > -----Original Message----- > From: [email protected]<mailto:[email protected]> > <[email protected]<mailto:[email protected]>> On Behalf Of Guo, Gua > Sent: Wednesday, June 21, 2023 3:02 PM > To: Hsu, VictorX <[email protected]<mailto:[email protected]>>; > [email protected]<mailto:[email protected]> > Cc: Gao, Liming <[email protected]<mailto:[email protected]>>; > Chan Laura > <[email protected]<mailto:[email protected]>>; Prakashan, Krishnadas > Veliyathuparambil > <[email protected]<mailto:[email protected]>>; > K N, Karthik > <[email protected]<mailto:[email protected]>> > Subject: Re: [edk2-devel] [PATCH] MdePkg: Move > gTraceHubDebugInfoHobGuid to MdePkg > > Reviewed-by: Gua Guo <[email protected]<mailto:[email protected]>> > > -----Original Message----- > From: Hsu, VictorX <[email protected]<mailto:[email protected]>> > Sent: Wednesday, June 21, 2023 3:01 PM > To: [email protected]<mailto:[email protected]> > Cc: Hsu, VictorX <[email protected]<mailto:[email protected]>>; Gao, > Liming > <[email protected]<mailto:[email protected]>>; Guo, Gua > <[email protected]<mailto:[email protected]>>; Chan Laura > <[email protected]<mailto:[email protected]>>; Prakashan, Krishnadas > Veliyathuparambil > <[email protected]<mailto:[email protected]>>; > K N, Karthik > <[email protected]<mailto:[email protected]>> > Subject: [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg > > From: VictorX Hsu <[email protected]<mailto:[email protected]>> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4486 > > Move gTraceHubDebugInfoHobGuid to MdePkg. > > Cc: Liming Gao <[email protected]<mailto:[email protected]>> > Cc: Guo Gua <[email protected]<mailto:[email protected]>> > Cc: Chan Laura <[email protected]<mailto:[email protected]>> > Cc: Prakashan Krishnadas Veliyathuparambil > <[email protected]<mailto:[email protected]>> > Cc: K N Karthik <[email protected]<mailto:[email protected]>> > Signed-off-by: VictorX Hsu > <[email protected]<mailto:[email protected]>> > --- > MdeModulePkg/MdeModulePkg.dec | 3 --- > .../Include/Guid/TraceHubDebugInfoHob.h | 0 > MdePkg/MdePkg.dec | 6 ++++++ > 3 files changed, 6 insertions(+), 3 deletions(-) rename {MdeModulePkg => > MdePkg}/Include/Guid/TraceHubDebugInfoHob.h (100%) > > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec index 95dd077e19..5b022b1f9f > 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -439,9 +439,6 @@ > ## Include/UniversalPayload/SerialPortInfo.h > gUniversalPayloadSerialPortInfoGuid = { 0xaa7e190d, 0xbe21, 0x4409, { 0x8e, > 0x67, 0xa2, 0xcd, 0xf, 0x61, 0xe1, 0x70 } } - ## > Include/Guid/TraceHubDebugInfoHob.h- gTraceHubDebugInfoHobGuid = > { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08, > 0x35 } }- ## GUID used for Boot Discovery Policy FormSet guid and related > variables. gBootDiscoveryPolicyMgrFormsetGuid = { 0x5b6f7107, 0xbb3c, > 0x4660, { 0x92, 0xcd, 0x54, 0x26, 0x90, 0x28, 0x0b, 0xbd } } diff --git > a/MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h > b/MdePkg/Include/Guid/TraceHubDebugInfoHob.h > similarity index 100% > rename from MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h > rename to MdePkg/Include/Guid/TraceHubDebugInfoHob.h > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index > b85614992b..3b5d1bac13 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -875,6 +875,12 @@ > ## Include/Protocol/CcMeasurement.h gEfiCcFinalEventsTableGuid = > { 0xdd4a4648, 0x2de7, 0x4665, { 0x96, 0x4d, 0x21, 0xd9, 0xef, 0x5f, 0xb4, > 0x46 }} + #+ # GUID used to store Trace Hub Debug information+ #+ ## > Include/Guid/TraceHubDebugInfoHob.h+ gTraceHubDebugInfoHobGuid = > { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08, > 0x35 } }+ [Guids.IA32, Guids.X64] ## Include/Guid/Cper.h > gEfiIa32X64ErrorTypeCacheCheckGuid = { 0xA55701F5, 0xE3EF, 0x43de, > { 0xAC, 0x72, 0x24, 0x9B, 0x57, 0x3F, 0xAD, 0x2C }}-- > 2.40.0.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106259): https://edk2.groups.io/g/devel/message/106259 Mute This Topic: https://groups.io/mt/99671889/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
