Reviewed-by: Bob Feng <bob.c.f...@intel.com> -----Original Message----- From: Srinivasan, ManickamX <manickamx.sriniva...@intel.com> Sent: Wednesday, August 23, 2023 3:29 PM To: devel@edk2.groups.io Cc: Srinivasan, ManickamX <manickamx.sriniva...@intel.com>; Feng, Bob C <bob.c.f...@intel.com>; Gao, Liming <gaolim...@byosoft.com.cn>; Chen, Christine <yuwei.c...@intel.com>; T V, Krishnamoorthy <krishnamoorthy....@intel.com> Subject: [PATCH] Platform/Intel: Enhance the BOARD_ID without PCH_TYPE support
The length of the Board ID is being updated based on the BOARD_ID string. If the PCH_TYPE is empty space/single quotes(''), removing the empty space/single quotes('') and concatenating the TARGET_PLATFORM_SHORT and BUILD flag strings. Cc: Bob Feng <bob.c.f...@intel.com> Cc: Liming Gao <gaolim...@byosoft.com.cn> Cc: Yuwei Chen <yuwei.c...@intel.com> Cc: T V Krishnamoorthy <krishnamoorthy....@intel.com> Signed-off-by: ManickamX Srinivasan <manickamx.sriniva...@intel.com> --- Platform/Intel/Tools/GenBiosId/GenBiosId.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Platform/Intel/Tools/GenBiosId/GenBiosId.py b/Platform/Intel/Tools/GenBiosId/GenBiosId.py index f823fdcad..fa3689867 100644 --- a/Platform/Intel/Tools/GenBiosId/GenBiosId.py +++ b/Platform/Intel/Tools/GenBiosId/GenBiosId.py @@ -142,7 +142,13 @@ def ParserInputFile(InputDict, NoTimestamp): EdkLogger("GenBiosId", FORMAT_INVALID, ExtraData=_ConfigItemInvalid % Item) _ConfigItem[Item]['Value'] = InputDict[Item] if len(_ConfigItem[Item]['Value']) != _ConfigItem[Item]['Length']: - EdkLogger("GenBiosId", FORMAT_INVALID, ExtraData=_ConfigLenInvalid % Item) + # The length of the Board ID is being updated based on the BOARD_ID string + #If the PCH_TYPE is empty space/single quotes(''), removing the empty space/single quotes('') and concatenating the TARGET_PLATFORM_SHORT and BUILD flag strings + if(_ConfigItem["BOARD_ID"]['Value'][3:5] == "\'\'"): + _ConfigItem["BOARD_ID"]['Value']=_ConfigItem["BOARD_ID"]['Value'][0:3]+_ConfigItem["BOARD_ID"]['Value'][5:len(_ConfigItem["BOARD_ID"]['Value'])] + _ConfigItem["BOARD_ID"]['Length']=len(_ConfigItem["BOARD_ID"]['Value']) + else: + EdkLogger("GenBiosId", FORMAT_INVALID, + ExtraData=_ConfigLenInvalid % Item) for Item in _ConfigItem: if not _ConfigItem[Item]['Value']: EdkLogger("GenBiosId", FORMAT_UNKNOWN_ERROR, ExtraData="Item %s is missing" % Item) -- 2.30.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108085): https://edk2.groups.io/g/devel/message/108085 Mute This Topic: https://groups.io/mt/100916084/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-