Hi Ard
V3 patch has updated.
Please help to check it.
Thanks.
-----Original Message-----
From: Ard Biesheuvel <a...@kernel.org>
Sent: Monday, September 11, 2023 9:14 PM
To: devel@edk2.groups.io; Liu, Linus <linus....@intel.com>
Cc: Zhang, Qi1 <qi1.zh...@intel.com>; Kumar, Rahul R <rahul.r.ku...@intel.com>;
Yao, Jiewen <jiewen....@intel.com>; Chen, Tina <tina.c...@intel.com>; Chen,
Xiao X <xiao.x.c...@intel.com>
Subject: Re: [edk2-devel] [PATCH v2] Pyrite support - Secure erase is only
available if encryption is supported.
On Thu, 7 Sept 2023 at 11:02, Linus Liu <linus....@intel.com> wrote:
>
> From: Linus Liu <linus....@intel.com>
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=3004
>
> Cc: Qi Zhang <qi1.zh...@intel.com>
> Cc: Rahul Kumar <rahul1.ku...@intel.com>
> Cc: Jiewen Yao <jiewen....@intel.com>
> Cc: Tina Chen <tina.c...@intel.com>
> Cc: Xiao X Chen <xiao.x.c...@intel.com>
This patch is missing a signed-off-by line
> ---
> SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
> b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
> index e2e77cbc24..ba9fa66c60 100644
> --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
> +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
> @@ -87,7 +87,11 @@ OpalSupportGetAvailableActions (
> // Secure erase is performed by generating a new encryption key
> // this is only available if encryption is supported
> //
> - AvalDiskActions->SecureErase = 1;
> + if (SupportedAttributes->MediaEncryption) {
> + AvalDiskActions->SecureErase = 1;
> + } else {
> + AvalDiskActions->SecureErase = 0;
> + }
> } else {
> AvalDiskActions->PsidRevert = 0;
> AvalDiskActions->SecureErase = 0;
> --
> 2.39.2.windows.1
>
>
>
> ------------
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#108368): https://edk2.groups.io/g/devel/message/108368
> Mute This Topic: https://groups.io/mt/101210886/1131722
> Group Owner: devel+ow...@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [a...@kernel.org]
> ------------
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108513): https://edk2.groups.io/g/devel/message/108513
Mute This Topic: https://groups.io/mt/101210886/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
--- Begin Message ---
From: Linus Liu <linus....@intel.com>
https://bugzilla.tianocore.org/show_bug.cgi?id=3004
Cc: Qi Zhang <qi1.zh...@intel.com>
Cc: Rahul Kumar <rahul1.ku...@intel.com>
Cc: Jiewen Yao <jiewen....@intel.com>
Cc: Tina Chen <tina.c...@intel.com>
Cc: Xiao X Chen <xiao.x.c...@intel.com>
Signed-off-by: Linus Liu <linus....@intel.com>
---
SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
index e2e77cbc24..ba9fa66c60 100644
--- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
+++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
@@ -87,7 +87,11 @@ OpalSupportGetAvailableActions (
// Secure erase is performed by generating a new encryption key
// this is only available if encryption is supported
//
- AvalDiskActions->SecureErase = 1;
+ if (SupportedAttributes->MediaEncryption) {
+ AvalDiskActions->SecureErase = 1;
+ } else {
+ AvalDiskActions->SecureErase = 0;
+ }
} else {
AvalDiskActions->PsidRevert = 0;
AvalDiskActions->SecureErase = 0;
--
2.39.2.windows.1
-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108511): https://edk2.groups.io/g/devel/message/108511
Mute This Topic: https://groups.io/mt/101307436/7575003
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [linus....@intel.com]
-=-=-=-=-=-=
--- End Message ---
