On 9/12/23 16:17, Laszlo Ersek wrote:
> "OvmfPkg/Include/IndustryStandard/Virtio095.h" defines the macro
> VIRTIO_SUBSYSTEM_CONSOLE with value 3; other locations in the tree already
> use it (such as ArmVirtPkg/PlatformBootManagerLib,
> OvmfPkg/VirtioSerialDxe). We should use it in
> OvmfPkg/PlatformBootManagerLib too, rather than the naked constant 3.
>
> Cc: Anthony Perard <anthony.per...@citrix.com>
> Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org>
> Cc: Gerd Hoffmann <kra...@redhat.com>
> Cc: Jiewen Yao <jiewen....@intel.com>
> Cc: Jordan Justen <jordan.l.jus...@intel.com>
> Cc: Julien Grall <jul...@xen.org>
> Cc: Marc-André Lureau <marcandre.lur...@redhat.com>
> Cc: Stefan Berger <stef...@linux.ibm.com>
> Beautifies: 163083fd80d5
> Signed-off-by: Laszlo Ersek <ler...@redhat.com>
> ---
> OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
> b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
> index 88c39df4aea9..d9f61757cf1b 100644
> --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
> +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
> @@ -1250,7 +1250,7 @@ DetectAndPreparePlatformVirtioDevicePath (
> DEBUG ((DEBUG_INFO, "%a:%d: id %d\n", __func__, __LINE__,
> VirtIo->SubSystemDeviceId));
>
> switch (VirtIo->SubSystemDeviceId) {
> - case 3:
> + case VIRTIO_SUBSYSTEM_CONSOLE:
> PrepareVirtioSerialDevicePath (Handle);
> break;
> default:
Please ignore "1/2" in the subject prefix; that was a mistake on my end
(not passing "-N" to git-format-patch).
This patch stands alone.
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108537): https://edk2.groups.io/g/devel/message/108537
Mute This Topic: https://groups.io/mt/101315751/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
