Hi Leif,

On 26/9/23 19:15, Leif Lindholm wrote:
There may be architectures on which there are benefits to
   eor r0, r0(, r0)
but ARM was never one of them. Change to more readable
   mov r0, #0
instead.

Signed-off-by: Leif Lindholm <quic_llind...@quicinc.com>
Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org>
Cc: Sami Mujawar <sami.muja...@arm.com>
---
  MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S   | 2 +-
  MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)


diff --git a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm 
b/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm
index e1eff758f7ab..ef02d85e0e66 100644
--- a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm
+++ b/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm
@@ -33,7 +33,7 @@
  SetJump
    MOV  R3, R13
    STM  R0, {R3-R12,R14}
-  EOR  R0, R0
+  MOV  RO, #0

Hmm. s/RO/R0/ ?

    BX   LR
;/**



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109290): https://edk2.groups.io/g/devel/message/109290
Mute This Topic: https://groups.io/mt/101600809/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to