Thanks for writing this patch.
Reviewed-by: Nhi Pham <[email protected]>
Tested-by: Nhi Pham <[email protected]>
Regards,
Nhi
On 10/11/2023 10:49 AM, Nickle Wang wrote:
Reviewed-by: Nickle Wang <[email protected]>
Regards,
Nickle
-----Original Message-----
From: [email protected] <[email protected]>
Sent: Wednesday, October 11, 2023 11:41 AM
To: [email protected]
Cc: Nickle Wang <[email protected]>; Igor Kulchytskyy <[email protected]>; Nhi
Pham <[email protected]>
Subject: [PATCH] RedfishPkg: Use base version SortLib for the specific modules
External email: Use caution opening links or attachments
From: Abner Chang <[email protected]>
BZ #: 4566
Update Redfish modules to use the small footprint version of base SortLib by the
means of module scoped subelement <LibraryClass>. With this the platform level
SortLib (full version) is not impacted if Redfish.dsc.inc is included in
platform DSC.
Signed-off-by: Abner Chang <[email protected]>
Cc: Nickle Wang <[email protected]>
Cc: Igor Kulchytskyy <[email protected]>
Cc: Nhi Pham <[email protected]>
---
RedfishPkg/RedfishComponents.dsc.inc | 10 ++++++++--
RedfishPkg/RedfishLibs.dsc.inc | 1 -
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/RedfishPkg/RedfishComponents.dsc.inc
b/RedfishPkg/RedfishComponents.dsc.inc
index 1c4284d3ecf..464ffc86064 100644
--- a/RedfishPkg/RedfishComponents.dsc.inc
+++ b/RedfishPkg/RedfishComponents.dsc.inc
@@ -16,9 +16,15 @@
!if $(REDFISH_ENABLE) == TRUE
RedfishPkg/RestJsonStructureDxe/RestJsonStructureDxe.inf
RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.inf
- RedfishPkg/RedfishRestExDxe/RedfishRestExDxe.inf
+ RedfishPkg/RedfishRestExDxe/RedfishRestExDxe.inf {
+ <LibraryClasses>
+ SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
+ }
RedfishPkg/RedfishCredentialDxe/RedfishCredentialDxe.inf
- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.inf
+ RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.inf {
+ <LibraryClasses>
+ SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
+ }
RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.inf
RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.inf
MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
diff --git a/RedfishPkg/RedfishLibs.dsc.inc b/RedfishPkg/RedfishLibs.dsc.inc
index
03b7ef6f328..5426957da87 100644
--- a/RedfishPkg/RedfishLibs.dsc.inc
+++ b/RedfishPkg/RedfishLibs.dsc.inc
@@ -14,7 +14,6 @@
!if $(REDFISH_ENABLE) == TRUE
RestExLib|RedfishPkg/Library/DxeRestExLib/DxeRestExLib.inf
Ucs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf
- SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
RedfishCrtLib|RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
JsonLib|RedfishPkg/Library/JsonLib/JsonLib.inf
RedfishLib|RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.inf
--
2.37.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109514): https://edk2.groups.io/g/devel/message/109514
Mute This Topic: https://groups.io/mt/101890398/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
