Hi Igor, If the DELETE request to BMC is handled by Redfish task, we need to return HTTP header to caller so caller can get Task URI. But from BIOS Redfish perspective, I don't see this use case yet.
Thanks, Nickle > -----Original Message----- > From: Igor Kulchytskyy <ig...@ami.com> > Sent: Thursday, October 26, 2023 8:50 PM > To: Chang, Abner <abner.ch...@amd.com>; Nickle Wang > <nick...@nvidia.com>; devel@edk2.groups.io > Cc: Nick Ramirez <nrami...@nvidia.com> > Subject: RE: [EXTERNAL] RE: [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP > headers to caller > > External email: Use caution opening links or attachments > > > Hi Nickle, > Just one quick question. > Is there any sense to return the headers for DELETE request? > Thank you, > Igor > > -----Original Message----- > From: Chang, Abner <abner.ch...@amd.com> > Sent: Thursday, October 26, 2023 2:10 AM > To: Nickle Wang <nick...@nvidia.com>; devel@edk2.groups.io > Cc: Igor Kulchytskyy <ig...@ami.com>; Nick Ramirez <nrami...@nvidia.com> > Subject: [EXTERNAL] RE: [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP > headers to caller > > > **CAUTION: The e-mail below is from an external source. Please exercise > caution before opening attachments, clicking links, or following guidance.** > > [AMD Official Use Only - General] > > Reviewed-by: Abner Chang <abner.ch...@amd.com> > > > -----Original Message----- > > From: Nickle Wang <nick...@nvidia.com> > > Sent: Tuesday, October 24, 2023 4:40 PM > > To: devel@edk2.groups.io > > Cc: Chang, Abner <abner.ch...@amd.com>; Igor Kulchytskyy > > <ig...@ami.com>; Nick Ramirez <nrami...@nvidia.com> > > Subject: [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to > > caller > > > > Caution: This message originated from an External Source. Use proper > > caution when opening attachments, clicking links, or responding. > > > > > > Call Ex interface to get HTTP headers and return to caller. > > > > Signed-off-by: Nickle Wang <nick...@nvidia.com> > > Cc: Abner Chang <abner.ch...@amd.com> > > Cc: Igor Kulchytskyy <ig...@ami.com> > > Cc: Nick Ramirez <nrami...@nvidia.com> > > --- > > RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c | 10 +++++++--- > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > diff --git a/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c > > b/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c > > index f4045044829a..5e06d516ba84 100644 > > --- a/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c > > +++ b/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c > > @@ -356,7 +356,7 @@ RedfishGetByUri ( > > > > ZeroMem (RedResponse, sizeof (REDFISH_RESPONSE)); > > > > - JsonValue = getUriFromService (RedfishService, Uri, > > &RedResponse- > > >StatusCode); > > + JsonValue = getUriFromServiceEx (RedfishService, Uri, > > &RedResponse- > > >Headers, &RedResponse->HeaderCount, &RedResponse->StatusCode); > > RedResponse->Payload = createRedfishPayload (JsonValue, > > RedfishService); > > > > // > > @@ -498,10 +498,12 @@ RedfishPatchToUri ( > > > > ZeroMem (RedResponse, sizeof (REDFISH_RESPONSE)); > > > > - JsonValue = (EDKII_JSON_VALUE)patchUriFromService ( > > + JsonValue = (EDKII_JSON_VALUE)patchUriFromServiceEx ( > > RedfishService, > > Uri, > > Content, > > + &(RedResponse->Headers), > > + &(RedResponse->HeaderCount), > > &(RedResponse->StatusCode) > > ); > > > > @@ -661,12 +663,14 @@ RedfishPostToUri ( > > > > ZeroMem (RedResponse, sizeof (REDFISH_RESPONSE)); > > > > - JsonValue = (EDKII_JSON_VALUE)postUriFromService ( > > + JsonValue = (EDKII_JSON_VALUE)postUriFromServiceEx ( > > RedfishService, > > Uri, > > Content, > > ContentSize, > > ContentType, > > + &(RedResponse->Headers), > > + &(RedResponse->HeaderCount), > > &(RedResponse->StatusCode) > > ); > > > > -- > > 2.17.1 > > -The information contained in this message may be confidential and proprietary > to American Megatrends (AMI). This communication is intended to be read only > by > the individual or entity to whom it is addressed or by their designee. If the > reader > of this message is not the intended recipient, you are on notice that any > distribution of this message, in any form, is strictly prohibited. Please > promptly > notify the sender by reply e-mail or by telephone at 770-246-8600, and then > delete or destroy all copies of the transmission. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110096): https://edk2.groups.io/g/devel/message/110096 Mute This Topic: https://groups.io/mt/102154017/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
