On 11/3/23 15:10, Wu, Jiaxin wrote: > Hi Laszlo, > > Thanks the feedback. > >> >> Is this somehow related to >> >> [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Clear CR4.CET before >> restoring MSR IA32_S_CET >> >> at >> >> https://edk2.groups.io/g/devel/message/110605 >> >> ? >> >> I'm not familiar with control flow integrity, but both patches seem to fix up >> problems with CET management. Therefore I would suggest to join forces and >> include all the patches in the same series. (Not same "patch", mind you -- >> different patches in the same series.) We've already asked for that other >> patch >> to be split up into series, anyway. >> > > I think it's total different issue. I found the system hang once we are > trying enable the CET. And root caused to the stack mismatch. > > Actually, the issue is not the CET itself, but due to the wrong use of CET > enable/disable by consumer (smm cpu driver). SMM CPU enable/disable the CET > feature improperly. > > For the patch you mentioned, it looks to handle the CET itself init bug, > right? if so, do you think we can keep to handle it separated or you still > think we need join forces in same series?
Thanks for the explanation; that clarifies that my suggestion to include both patches in the same series was wrong. So please feel free to proceed separately. Thanks, Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110626): https://edk2.groups.io/g/devel/message/110626 Mute This Topic: https://groups.io/mt/102362300/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
