Thanks!
https://github.com/tianocore/edk2/pull/5023 raised.
/
Leif
On Thu, Nov 09, 2023 at 21:42:38 +0800, gaoliming via groups.io wrote:
> Leif:
> Sure. This patch can be merged for this stable tag.
>
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: [email protected] <[email protected]> 代表 Leif Lindholm
> > 发送时间: 2023年11月7日 21:13
> > 收件人: Yeping Song (QUIC) <[email protected]>;
> > [email protected]; Liming Gao <[email protected]>
> > 抄送: Rebecca Cran <[email protected]>; Bob Feng
> > <[email protected]>; Yuwei Chen <[email protected]>; Ard
> > Biesheuvel <[email protected]>; Sami Mujawar
> > <[email protected]>; Kinney, Michael D <[email protected]>
> > 主题: Re: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: drop
> > -mgeneral-regs-only for AArch64 CLANGDWARF
> >
> > Liming,
> >
> > You reviewed this patch before the stable tag. Am I OK to stage a github
> > PR for this change?
> >
> > Reviewed-by: Leif Lindholm <[email protected]>
> >
> > Regards,
> >
> > Leif
> >
> > On 2023-11-07 13:11, Yeping Song (QUIC) wrote:
> > > Hi all,
> > > I would like for this to be include in stable tag. Please help to review
> > > and
> > merge this patch into stable release.
> > > Thanks
> > > Yepings
> > >
> > >
> > > -----Original Message-----
> > > From: [email protected] <[email protected]> On Behalf Of Yeping
> > Song
> > > Sent: Saturday, November 4, 2023 12:38 AM
> > > To: [email protected]
> > > Cc: Yeping Song (QUIC) <[email protected]>; Rebecca Cran
> > <[email protected]>; Liming Gao <[email protected]>; Bob Feng
> > <[email protected]>; Yuwei Chen <[email protected]>; Ard
> > Biesheuvel <[email protected]>; Leif Lindholm (QUIC)
> > <[email protected]>; Sami Mujawar <[email protected]>
> > > Subject: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: drop
> > -mgeneral-regs-only for AArch64 CLANGDWARF
> > >
> > > WARNING: This email originated from outside of Qualcomm. Please be wary
> > of any links or attachments, and do not enable macros.
> > >
> > > Commit 0df6c8c157af9 ("BaseTools/tools_def AARCH64:
> > > avoid SIMD registers in XIP code")
> > > adds -mgeneral-regs-only to GCC_AARCH64_CC_XIPFLAGS, in order to avoid
> > a bug present in certain versions of GCC.
> > > This was never a problem for clang.
> > > That's given the history of what the problem is.
> > > Then we can describe how we fix it:
> > > Change *_CLANGDWARF_AARCH64_CC_XIPFLAGS to set the required
> > -mstrict-align option instead of importing the whole GCC variable.
> > >
> > > Signed-off-by: Yeping Song <[email protected]>
> > > Cc: Rebecca Cran <[email protected]>
> > > Cc: Liming Gao <[email protected]>
> > > Cc: Bob Feng <[email protected]>
> > > Cc: Yuwei Chen <[email protected]>
> > > Cc: Ard Biesheuvel <[email protected]>
> > > Cc: Leif Lindholm <[email protected]>
> > > Cc: Sami Mujawar <[email protected]>
> > > ---
> > > BaseTools/Conf/tools_def.template | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/BaseTools/Conf/tools_def.template
> > b/BaseTools/Conf/tools_def.template
> > > index 5bd5283655ea..c34ecfd557c5 100755
> > > --- a/BaseTools/Conf/tools_def.template
> > > +++ b/BaseTools/Conf/tools_def.template
> > > @@ -2015,7 +2015,7 @@ DEFINE CLANGDWARF_AARCH64_DLINK_FLAGS
> > = DEF(CLANGDWARF_AARCH64_TARGET) DEF(GCC_
> > > *_CLANGDWARF_AARCH64_RC_FLAGS =
> > DEF(GCC_AARCH64_RC_FLAGS) DEF(GCC_AARCH64_RC_BTI_FLAGS)
> > > *_CLANGDWARF_AARCH64_VFRPP_FLAGS =
> > DEF(GCC_VFRPP_FLAGS) DEF(CLANGDWARF_AARCH64_TARGET)
> > $(PLATFORM_FLAGS)
> > > *_CLANGDWARF_AARCH64_ASLPP_FLAGS =
> > DEF(GCC_ASLPP_FLAGS) DEF(CLANGDWARF_AARCH64_TARGET)
> > > -*_CLANGDWARF_AARCH64_CC_XIPFLAGS =
> > DEF(GCC_AARCH64_CC_XIPFLAGS)
> > > +*_CLANGDWARF_AARCH64_CC_XIPFLAGS = -mstrict-align
> > >
> > > DEBUG_CLANGDWARF_AARCH64_CC_FLAGS =
> > DEF(CLANGDWARF_AARCH64_CC_FLAGS) $(PLATFORM_FLAGS) -flto -O1
> > > DEBUG_CLANGDWARF_AARCH64_DLINK_FLAGS =
> > DEF(CLANGDWARF_AARCH64_DLINK_FLAGS) -flto -Wl,-O1 -fuse-ld=lld
> > -L$(WORKSPACE)/ArmPkg/Library/GccLto -llto-aarch64
> > -Wl,-plugin-opt=-pass-through=-llto-aarch64 -Wl,--no-pie,--no-relax
> > > --
> > > 2.25.1
> > >
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
>
>
>
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110987): https://edk2.groups.io/g/devel/message/110987
Mute This Topic: https://groups.io/mt/102485456/21656
Group Owner: [email protected]
Unsubscribe:
https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
