On Tue, 28 Nov 2023 at 18:15, Michael Kubacki <[email protected]> wrote: > > On 11/28/2023 4:51 AM, Ard Biesheuvel wrote: > > On Tue, 28 Nov 2023 at 01:15, <[email protected]> wrote: > >> > >> From: Michael Kubacki <[email protected]> > >> > >> This series contains two changes: > >> > >> 1. To fix a compiler warning with the current state of code. > >> 2. To update the code to pass the integer width needed for a > >> comparison to set EFI_MEMORY_XP in the GCD attribute returned > >> for a given page attribute. > >> > >> Cc: Leif Lindholm <[email protected]> > >> Cc: Ard Biesheuvel <[email protected]> > >> Cc: Sami Mujawar <[email protected]> > >> > >> Michael Kubacki (2): > >> ArmPkg/Drivers/CpuDxe: Explicitly cast table entry > >> ArmPkg/Drivers/CpuDxe: Use lower and upper attributes > >> > > > > Thanks for the fixes. This code is in a rather poor state, unfortunately. > > > > I don't quite get the motivation for fixing this using two different > > patches: the implicit UINT32 cast obviously loses some attributes (the > > ones in the 12 upper bits, notably UXN and PXN), so making it explicit > > removes the warning but preserves the bug. (If GCC had better > > diagnostics, we'd spotted this problem years ago) > > > > Maybe it is sufficient to simply squash the two patches together? > > > I wanted to leave that open to discussion and maintainer discretion. I > think a squash is fine and sent a v2 with it done. >
Thanks. I'll go and merge that. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111818): https://edk2.groups.io/g/devel/message/111818 Mute This Topic: https://groups.io/mt/102841999/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
