Reviewed-by: Chasel Chiu <[email protected]>
Thanks, Chasel > -----Original Message----- > From: Desimone, Nathaniel L <[email protected]> > Sent: Thursday, November 30, 2023 4:06 PM > To: [email protected] > Cc: Chiu, Chasel <[email protected]>; Ni, Ray <[email protected]>; > Chaganty, > Rangasai V <[email protected]>; Gao, Liming > <[email protected]>; Kinney, Michael D <[email protected]>; > Taylor Beebe <[email protected]>; Kubacki, Michael > <[email protected]> > Subject: [edk2-platforms][PATCH v1] Intel-MinPlatform: Fix DxeCore Build > Failures > > Commit 7284c44 in edk2 introduces an incompatibility that causes any project > that uses DxeMain.inf to fail to build. This is due to the addition of > ImagePropertiesRecordLib, and a new added dependency on that library in > DxeMain. Platforms will not have this LibraryClass defined in their DSC yet > and > hence currently fail to build. > > This changes addes ImagePropertiesRecordLib to CoreCommonLib.dsc, which will > be picked up by all platforms that adhere to the MinPlatform Architecture. > This > will fix most Intel platform builds in edk2-platforms. > > Cc: Chasel Chiu <[email protected]> > Cc: Ray Ni <[email protected]> > Cc: Sai Chaganty <[email protected]> > Cc: Liming Gao <[email protected]> > Cc: Michael D Kinney <[email protected]> > Cc: Taylor Beebe <[email protected]> > Cc: Michael Kubacki <[email protected]> > Signed-off-by: Nate DeSimone <[email protected]> > --- > Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > index 300b7d7652..e40b2ff6e1 100644 > --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > @@ -174,3 +174,4 @@ > > VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVari > ableFlashInfoLib.inf > > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf > > VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Variabl > ePolicyHelperLib.inf > + > + ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib > + /ImagePropertiesRecordLib.inf > -- > 2.39.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111926): https://edk2.groups.io/g/devel/message/111926 Mute This Topic: https://groups.io/mt/102906021/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
