On 11/20/23 13:42, Wu, Jiaxin wrote: > For core id in cpu features library, I agree it should be not easy or > simple change to 0x1f. > > > > But in SMM CPU, there is no usage case depends on the number of cores > retrieved from cupid 0x0b return value, only PackageId will be used. So, > this patch doesn’t do bad things, should no regression issue. I agree > with Ray’s explanation that “CPUID.0B.PackageId == CPUID.1F.PackageId”, > thus no need update for the PackageId update. > > > > I checked the latest SDM: > > > > “The sub-leaves of CPUID leaf 0BH describe an ordered hierarchy of > logical processors starting from the smallest-scoped domain of a Logical > Processor (sub-leaf index 0) to the Core domain (sub-leaf index 1) to > the largest-scoped domain (the last valid sub-leaf index) **that is > implicitly subordinate to the unenumerated highest-scoped domain of the > processor package (socket)**” > > > > Looks it already updated to indicate the largest-scoped domain is package. > > > > With all above, I agree to drop this path, but other 2 patches in this > set should be ok. Thanks Ray help clarify this.
Merged the first two patches in the series as commits ad0b1cc144b56fcbd8d369eaff6eaf5f3020efe7 and 7eb504060787c9c37d5b3c33f5d65021d553ea3f, via <https://github.com/tianocore/edk2/pull/5125>. Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112229): https://edk2.groups.io/g/devel/message/112229 Mute This Topic: https://groups.io/mt/102602853/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
