Hi Zack, Could you please review the change? Thanks, Heng > -----Original Message----- > From: Kasbekar, Saloni <saloni.kasbe...@intel.com> > Sent: Saturday, December 2, 2023 5:25 AM > To: Luo, Heng <heng....@intel.com>; devel@edk2.groups.io > Cc: Clark-williams, Zachary <zachary.clark-willi...@intel.com> > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if not connect > to AP > > Reviewed-by: Kasbekar, Saloni <saloni.kasbe...@intel.com> > > Thanks, > Saloni > > -----Original Message----- > From: Luo, Heng <heng....@intel.com> > Sent: Monday, November 27, 2023 7:07 PM > To: devel@edk2.groups.io > Cc: Kasbekar, Saloni <saloni.kasbe...@intel.com>; Clark-williams, Zachary > <zachary.clark-willi...@intel.com> > Subject: [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to > AP > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4605 > > When UEFI Wi-Fi is in BSS connected state, the platform is considered as a > static and Wi-Fi roaming support is not needed. > Wifi connection manager should not initiate Scan requests in this state affect > BSS client connectivity and must be avoided. > Triger regularly scan only if not connect to AP. > > Signed-off-by: Heng Luo <heng....@intel.com> > Cc: Saloni Kasbekar <saloni.kasbe...@intel.com> > Cc: Zachary Clark-williams <zachary.clark-willi...@intel.com> > --- > NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > index d1182e52bd..4c5460b65c 100644 > --- a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > +++ b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > @@ -1506,8 +1506,8 @@ WifiMgrOnTimerTick ( > } Nic->ScanTickTime++;- if (((Nic->ScanTickTime > > WIFI_SCAN_FREQUENCY) || Nic->OneTimeScanRequest) &&- (Nic- > >ScanState == WifiMgrScanFinished))+ if ((((Nic->ScanTickTime > > WIFI_SCAN_FREQUENCY) && (Nic->ConnectState != WifiMgrConnectedToAp)) > ||+ Nic->OneTimeScanRequest) && (Nic->ScanState == > WifiMgrScanFinished)) { Nic->OneTimeScanRequest = FALSE; Nic- > >ScanTickTime = 0;-- > 2.31.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112272): https://edk2.groups.io/g/devel/message/112272 Mute This Topic: https://groups.io/mt/102844565/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
