Hi Sahil,

Please see my response for Patch 3/5.

Regards,

Sami Mujawar

On 16/11/2023 11:45 am, sahil wrote:
Enable persistent storage on QSPI flash device.

Signed-off-by: sahil <sa...@arm.com>
---
  Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 20 ++++++++++++++------
  Platform/ARM/N1Sdp/N1SdpPlatform.fdf |  4 +++-
  2 files changed, 17 insertions(+), 7 deletions(-)

diff --git a/Platform/ARM/N1Sdp/N1SdpPlatform.dsc 
b/Platform/ARM/N1Sdp/N1SdpPlatform.dsc
index d04b22d3ef51..10fe2db9e1b1 100644
--- a/Platform/ARM/N1Sdp/N1SdpPlatform.dsc
+++ b/Platform/ARM/N1Sdp/N1SdpPlatform.dsc
@@ -4,7 +4,7 @@
  # This provides platform specific component descriptions and libraries that

  # conform to EFI/Framework standards.

  #

-# Copyright (c) 2018 - 2021, ARM Limited. All rights reserved.<BR>

+# Copyright (c) 2018 - 2023, ARM Limited. All rights reserved.<BR>

  #

  # SPDX-License-Identifier: BSD-2-Clause-Patent

  #

@@ -44,6 +44,9 @@
    # file explorer library support

    FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf

+  # NOR flash support

+  NorFlashInfoLib|EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf

+

  [LibraryClasses.common.SEC]

    HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf

    
MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf

@@ -161,11 +164,9 @@
    # ACPI Table Version

    gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20

-  # Runtime Variable storage

-  gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvStoreReserved|0

-  gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnable|TRUE

-  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000

-  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x2800

+  # NOR flash support

+  gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase|0x18F00000

+  gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize|0x00020000

  
################################################################################

  #

@@ -197,6 +198,12 @@
        gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8000000F

    }

+  # NOR flash support

+  Platform/ARM/N1Sdp/Drivers/CadenceQspiDxe/CadenceQspiDxe.inf {

+      <LibraryClasses>

+      
NorFlashPlatformLib|Silicon/ARM/NeoverseN1Soc/Library/NorFlashLib/NorFlashLib.inf

+  }

+

    # Architectural Protocols

    ArmPkg/Drivers/CpuDxe/CpuDxe.inf

    ArmPkg/Drivers/ArmGic/ArmGicDxe.inf

@@ -217,6 +224,7 @@
    MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf {

      <LibraryClasses>

        NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf

+      
NULL|EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf

        BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf

    }

diff --git a/Platform/ARM/N1Sdp/N1SdpPlatform.fdf 
b/Platform/ARM/N1Sdp/N1SdpPlatform.fdf
index e5e24ea50294..4329f892f7c5 100644
--- a/Platform/ARM/N1Sdp/N1SdpPlatform.fdf
+++ b/Platform/ARM/N1Sdp/N1SdpPlatform.fdf
@@ -1,7 +1,7 @@
  ## @file

  #  FDF file of N1Sdp

  #

-#  Copyright (c) 2018 - 2021, ARM Limited. All rights reserved.<BR>

+#  Copyright (c) 2018 - 2023, ARM Limited. All rights reserved.<BR>

  #

  #  SPDX-License-Identifier: BSD-2-Clause-Patent

  ##

@@ -140,6 +140,8 @@ READ_LOCK_STATUS   = TRUE
    INF ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf

    INF ArmPkg/Drivers/TimerDxe/TimerDxe.inf

+  INF Platform/ARM/N1Sdp/Drivers/CadenceQspiDxe/CadenceQspiDxe.inf

+

    INF Platform/ARM/Drivers/BootMonFs/BootMonFs.inf

    INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112645): https://edk2.groups.io/g/devel/message/112645
Mute This Topic: https://groups.io/mt/102625037/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to