Merged: https://github.com/tianocore/edk2/pull/5291
> -----Original Message-----
> From: Kinney, Michael D <michael.d.kin...@intel.com>
> Sent: Tuesday, January 23, 2024 9:26 AM
> To: devel@edk2.groups.io; Huang, Qing <qing.hu...@intel.com>
> Cc: Kinney, Michael D <michael.d.kin...@intel.com>
> Subject: RE: [edk2-devel] [PATCH v1] MdePkg/BaseCpuLibNull: Add stub
> function of StandardSignatureIsAuthenticAMD() in CpuLibNull instance
>
> Hi Qing,
>
> Thank you for this update to add the missing API to BaseCpuLibNull.
>
> There are a few very minor comments below. I will make those updates
> in the PR for merge. With those changes:
>
> Reviewed-by: Michael D Kinney <michael.d.kin...@intel.com>
>
> Mike
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Huang,
> > Qing
> > Sent: Tuesday, January 23, 2024 3:37 AM
> > To: devel@edk2.groups.io
> > Cc: Huang, Qing <qing.hu...@intel.com>
> > Subject: [edk2-devel] [PATCH v1] MdePkg/BaseCpuLibNull: Add stub
> > function of StandardSignatureIsAuthenticAMD() in CpuLibNull instance
>
> Subject line too long
>
> >
> > CpuLib.h exposes StandardSignatureIsAuthenticAMD() API and we require
> > stub function in its BaseCpuLibNull library
> > instance to avoid potential link issue.
> >
>
> Missing Cc for MdePkg maintainers.
>
> > Signed-off-by: Qing Huang <qing.hu...@intel.com>
> > ---
> > MdePkg/Library/BaseCpuLibNull/BaseCpuLibNull.c | 17 ++++++++++++++++-
> > 1 file changed, 16 insertions(+), 1 deletion(-)
> >
> > diff --git a/MdePkg/Library/BaseCpuLibNull/BaseCpuLibNull.c
> > b/MdePkg/Library/BaseCpuLibNull/BaseCpuLibNull.c
> > index 3ba7a35096..ba7981551d 100644
> > --- a/MdePkg/Library/BaseCpuLibNull/BaseCpuLibNull.c
> > +++ b/MdePkg/Library/BaseCpuLibNull/BaseCpuLibNull.c
> > @@ -1,7 +1,7 @@
> > /** @file
> > Null instance of CPU Library.
> >
> > - Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
> > + Copyright (c) 2020 - 2024, Intel Corporation. All rights
> > reserved.<BR>
>
> Updating end year not required for Intel copyright statements.
>
> > SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> > **/
> > @@ -35,3 +35,18 @@ CpuFlushTlb (
> > )
> > {
> > }
> > +
> > +/**
> > + Determine if the standard CPU signature is "AuthenticAMD".
> > +
> > + @retval TRUE The CPU signature matches.
> > + @retval FALSE The CPU signature does not match.
> > +**/
> > +BOOLEAN
> > +EFIAPI
> > +StandardSignatureIsAuthenticAMD (
> > + VOID
> > + )
> > +{
> > + return FALSE;
> > +}
> > --
> > 2.42.0.windows.2
> >
> >
> >
> >
> >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114231): https://edk2.groups.io/g/devel/message/114231
Mute This Topic: https://groups.io/mt/103907626/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
