Hi Liming, I do not see any reviews of this patch.
What is the status? Mike > -----Original Message----- > From: [email protected] <[email protected]> On Behalf Of Dhaval > Sharma > Sent: Monday, January 8, 2024 7:00 AM > To: [email protected] > Cc: Gao, Liming <[email protected]>; Liu, Zhiguang > <[email protected]>; Bi, Dandan <[email protected]>; Pedro > Falcato <[email protected]>; Chiu, Chasel <[email protected]> > Subject: [edk2-devel] [PATCH v4 1/1] MdeModulePkg/AcpiTableDxe: Prefer > xDSDT over DSDT when installing tables > > As per ACPI Spec 6.5+ Table 5-9 if xDSDT is available, > it should be used first. Handle required flow when xDSDT > is absent or present. > > Test: Tested on RISCV64 Qemu platform with xDSDT and booted to > linux kernel. > > Cc: Liming Gao <[email protected]> > Cc: Zhiguang Liu <[email protected]> > Cc: Dandan Bi <[email protected]> > Cc: Pedro Falcato <[email protected]> > Cc: [email protected] > Signed-off-by: Dhaval Sharma <[email protected]> > Acked-by: Chasel Chiu <chasel.chiu@...> > --- > > Notes: > v4: > - Fix typos and commit message adding more clarity to patch subject > v3: > - Added description of ACPI spec clarification based on which this > patch is created > - Optimizing if-else flow > v2: > - Added proper indentation for else if > > MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c | 23 > ++++++++++++++------ > 1 file changed, 16 insertions(+), 7 deletions(-) > > diff --git > a/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c > b/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c > index e09bc9b704f5..61af6047a2a7 100644 > --- a/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c > +++ b/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c > @@ -1892,14 +1892,23 @@ InstallAcpiTableFromHob ( > } > > } > > > > - if (((EFI_ACPI_3_0_FIXED_ACPI_DESCRIPTION_TABLE *)ChildTable)- > >Dsdt != 0) { > > + // > > + // First check if xDSDT is available, as that is preferred as > per > > + // ACPI Spec 6.5+ Table 5-9 X_DSDT definition > > + // > > + if (((EFI_ACPI_3_0_FIXED_ACPI_DESCRIPTION_TABLE *)ChildTable)- > >XDsdt != 0) { > > + TableToInstall = (VOID > *)(UINTN)((EFI_ACPI_3_0_FIXED_ACPI_DESCRIPTION_TABLE *)ChildTable)- > >XDsdt; > > + } else if (((EFI_ACPI_3_0_FIXED_ACPI_DESCRIPTION_TABLE > *)ChildTable)->Dsdt != 0) { > > TableToInstall = (VOID > *)(UINTN)((EFI_ACPI_3_0_FIXED_ACPI_DESCRIPTION_TABLE *)ChildTable)- > >Dsdt; > > - Status = AddTableToList (AcpiTableInstance, > TableToInstall, TRUE, Version, TRUE, &TableKey); > > - if (EFI_ERROR (Status)) { > > - DEBUG ((DEBUG_ERROR, "InstallAcpiTableFromHob: Fail to add > ACPI table DSDT\n")); > > - ASSERT_EFI_ERROR (Status); > > - break; > > - } > > + } else { > > + break; > > + } > > + > > + Status = AddTableToList (AcpiTableInstance, TableToInstall, > TRUE, Version, TRUE, &TableKey); > > + if (EFI_ERROR (Status)) { > > + DEBUG ((DEBUG_ERROR, "InstallAcpiTableFromHob: Fail to add > ACPI table DSDT\n")); > > + ASSERT_EFI_ERROR (Status); > > + break; > > } > > } > > } > > -- > 2.39.2 > > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#113401): > https://edk2.groups.io/g/devel/message/113401 > Mute This Topic: https://groups.io/mt/103598583/1643496 > Group Owner: [email protected] > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [[email protected]] > -=-=-=-=-=-= > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114247): https://edk2.groups.io/g/devel/message/114247 Mute This Topic: https://groups.io/mt/103598583/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
