On Fri, Feb 16, 2024 at 5:26 PM Michael D Kinney <michael.d.kin...@intel.com> wrote: > > I think adding a #define to define register to nothings makes sense.
No, the correct fix is to remove 'register' from the parameters. It does not change the ABI, nor the API, nor are the parameters "register"-ified in the C or C++ standards. AFAIK the only side effect of 'register' (on modern compilers, aka GCC/clang/MSVC, etc) is that you can't grab its address (https://godbolt.org/z/cx9zf9n9n). But that's not a problem in this case. -- Pedro -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115552): https://edk2.groups.io/g/devel/message/115552 Mute This Topic: https://groups.io/mt/104393456/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
