> > > + > > + if (CpuMpData->ApLoopMode != ApInHltLoop) { > > + MpHandOff->StartupSignalValue = MP_HAND_OFF_SIGNAL; > > + MpHandOff->WaitLoopExecutionMode = sizeof (VOID *); > > + } > > + } > > As noted elsewhere, these fields don't belong in the loop (they don't > belong to MP_HAND_OFF, going forward); the two of them together should > form a new singleton structure. >
I agree the StartupSignalValue and WaitLoopExecutionMode are duplicated fields if multiple MP_HAND_OFF instances are created. I am ok to leave them as duplicates in this patch series. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115638): https://edk2.groups.io/g/devel/message/115638 Mute This Topic: https://groups.io/mt/104369848/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-