[AMD Official Use Only - General] Looks good, thank you!
Reviewed-by: Abner Chang <abner.ch...@amd.com> > -----Original Message----- > From: Mike Maslenkin <mike.maslen...@gmail.com> > Sent: Wednesday, February 21, 2024 8:13 AM > To: devel@edk2.groups.io > Cc: Mike Maslenkin <mike.maslen...@gmail.com>; Chang, Abner > <abner.ch...@amd.com>; Nickle Wang <nick...@nvidia.com>; Igor > Kulchytskyy <ig...@ami.com> > Subject: [PATCH 4/4] RedfishClientPkg: use Json value from a function > argument > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > This patch replaces value Private->Json with Json used as second argument > for RedfishIdentifyResource(). Currently Json argument is not used at all > and the pattern for caller side is: > Status = RedfishIdentifyResourceCommon (Private, Private->Json); > > So in scope of RedfishIdentifyResourceCommon Json actually is the same > value as Private->Json. Let's make code a bit cleaner. > > Cc: Abner Chang <abner.ch...@amd.com> > Cc: Nickle Wang <nick...@nvidia.com> > Cc: Igor Kulchytskyy <ig...@ami.com> > Signed-off-by: Mike Maslenkin <mike.maslen...@gmail.com> > --- > RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c | 2 +- > .../Features/BootOption/v1_0_4/Common/BootOptionCommon.c | 2 +- > .../ComputerSystem/v1_13_0/Common/ComputerSystemCommon.c | 2 > +- > .../ComputerSystem/v1_5_0/Common/ComputerSystemCommon.c | 2 > +- > RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c > | 2 +- > 5 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > index 0ae841499692..f3f993c8782e 100644 > --- a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > @@ -729,7 +729,7 @@ RedfishIdentifyResourceCommon ( > EFI_STRING EndOfChar; > > REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG_LIST ConfigLangList; > > > > - Supported = RedfishIdentifyResource (Private->Uri, Private->Json); > > + Supported = RedfishIdentifyResource (Private->Uri, Json); > > if (Supported) { > > Status = RedfishFeatureGetUnifiedArrayTypeConfigureLang > (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION, > REDPATH_ARRAY_PATTERN, &ConfigLangList); > > if (EFI_ERROR (Status)) { > > diff --git > a/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCom > mon.c > b/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCom > mon.c > index 0b9f2bf28434..f471c01c3790 100644 > --- > a/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCom > mon.c > +++ > b/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCom > mon.c > @@ -791,7 +791,7 @@ RedfishIdentifyResourceCommon ( > { > > BOOLEAN Supported; > > > > - Supported = RedfishIdentifyResource (Private->Uri, Private->Json); > > + Supported = RedfishIdentifyResource (Private->Uri, Json); > > if (Supported) { > > return EFI_SUCCESS; > > } > > diff --git > a/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Common/Compute > rSystemCommon.c > b/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Common/Compute > rSystemCommon.c > index cee6c8bf9ba1..d69fc176ad94 100644 > --- > a/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Common/Compute > rSystemCommon.c > +++ > b/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Common/Compute > rSystemCommon.c > @@ -848,7 +848,7 @@ RedfishIdentifyResourceCommon ( > EFI_STRING EndOfChar; > > REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG_LIST ConfigLangList; > > > > - Supported = RedfishIdentifyResource (Private->Uri, Private->Json); > > + Supported = RedfishIdentifyResource (Private->Uri, Json); > > if (Supported) { > > Status = RedfishFeatureGetUnifiedArrayTypeConfigureLang > (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION, > REDPATH_ARRAY_PATTERN, &ConfigLangList); > > if (EFI_ERROR (Status)) { > > diff --git > a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/Computer > SystemCommon.c > b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/Computer > SystemCommon.c > index a67ef3dac283..11bcb5f76cab 100644 > --- > a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/Computer > SystemCommon.c > +++ > b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/Computer > SystemCommon.c > @@ -1718,7 +1718,7 @@ RedfishIdentifyResourceCommon ( > EFI_STRING EndOfChar; > > REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG_LIST ConfigLangList; > > > > - Supported = RedfishIdentifyResource (Private->Uri, Private->Json); > > + Supported = RedfishIdentifyResource (Private->Uri, Json); > > if (Supported) { > > Status = RedfishFeatureGetUnifiedArrayTypeConfigureLang > (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION, > REDPATH_ARRAY_PATTERN, &ConfigLangList); > > if (EFI_ERROR (Status)) { > > diff --git > a/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c > b/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon. > c > index eb52c68c5dcb..00a69f748c3c 100644 > --- > a/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c > +++ > b/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon. > c > @@ -2516,7 +2516,7 @@ RedfishIdentifyResourceCommon ( > EFI_STRING EndOfChar; > > REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG_LIST ConfigLangList; > > > > - Supported = RedfishIdentifyResource (Private->Uri, Private->Json); > > + Supported = RedfishIdentifyResource (Private->Uri, Json); > > if (Supported) { > > Status = RedfishFeatureGetUnifiedArrayTypeConfigureLang > (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION, > REDPATH_ARRAY_PATTERN, &ConfigLangList); > > if (EFI_ERROR (Status)) { > > -- > 2.32.0 (Apple Git-132) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115699): https://edk2.groups.io/g/devel/message/115699 Mute This Topic: https://groups.io/mt/104479574/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-