On 2/27/24 12:41, Gerd Hoffmann wrote: > Move the WaitLoopExecutionMode and StartupSignalValue fields to a > separate HOB with the new struct. > > Signed-off-by: Gerd Hoffmann <kra...@redhat.com> > --- > UefiCpuPkg/Library/MpInitLib/MpHandOff.h | 13 ++++++-- > UefiCpuPkg/Library/MpInitLib/MpLib.h | 3 +- > UefiCpuPkg/Library/MpInitLib/MpLib.c | 38 ++++++++++++++++++++---- > UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 34 +++++++++++++-------- > 4 files changed, 66 insertions(+), 22 deletions(-)
Ah, please also append a few sentences to the commit message -- we should explain *why* this change is good: WaitLoopExecutionMode and StartupSignalValue are independent of processor index ranges; they are global to MpInitLib (i.e., the entire system). Therefore they shouldn't be repeated in every MpHandOff GUID HOB. Thanks! Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116079): https://edk2.groups.io/g/devel/message/116079 Mute This Topic: https://groups.io/mt/104600810/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
