On 3/7/24 10:04, joeyli via groups.io wrote:
> Hi Laszlo,
>
> On Tue, Mar 05, 2024 at 09:53:33AM +0100, Laszlo Ersek wrote:
>> On 3/4/24 12:37, joeyli via groups.io wrote:
>>> Hi,
>>>
>>> On Wed, Feb 07, 2024 at 04:02:52PM +0800, joeyli via groups.io wrote:
>>>> On Wed, Feb 07, 2024 at 03:55:49PM +0800, joeyli wrote:
>>>>> Hi Laszlo,
>>>>>
>>>>> First, thanks for your review!
>>>>>
>>>>> On Mon, Feb 05, 2024 at 05:41:25PM +0100, Laszlo Ersek wrote:
>>>>>> On 2/4/24 10:29, Lee, Chun-Yi wrote:
>>>>>>> In case PcdFirmwareReleaseDateString is not set use a valid date
>>>>>>> as fallback. But the default valid date can _NOT_ pass the Microsoft
>>>>>>> SVVP test "Check SMBIOS Table Specific Requirements". The test emitted
>>>>>>> the error message:
>>>>>>>
>>>>>>> BIOS Release Date string is unexpected length: 8. This string must be in
>>>>>>> MM/DD/YYYY format. No other format is allowed and no additional
>>>>>>> information
>>>>>>> may be included. See field description in the SMBIOS specification.
>>>>>>>
>>>>>>> Base on SMBIOS spec v3.7.0:
>>>>>>>
>>>>>>> 08h 2.0+ BIOS Release Date BYTE STRING
>>>>>>> String number of the BIOS release date. The date
>>>>>>> string, if supplied, is in either mm/dd/yy or
>>>>>>> mm/dd/yyyy format. If the year portion of the string
>>>>>>> is two digits, the year is assumed to be 19yy.
>>>>>>> NOTE: The mm/dd/yyyy format is required for SMBIOS
>>>>>>> version 2.3 and later.
>>>>>>>
>>>>>>> So, let's tweek the fallback release date again.
>>>>>>>
>>>>>>> Fixes: a0f9628705e3 ("OvmfPkg/SmbiosPlatformDxe: tweak fallback release
>>>>>>> date") [edk2-stable202305~327]
>>>>>>> Signed-off-by: "Lee, Chun-Yi" <j...@suse.com>
>>>>>>> ---
>>>>>>> OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +-
>>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>>>
>>>>>>> diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
>>>>>>> b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
>>>>>>> index 0ca3776045..e929da6b81 100644
>>>>>>> --- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
>>>>>>> +++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
>>>>>>> @@ -160,7 +160,7 @@ InstallAllStructures (
>>>>>>> DateStr = (CHAR16 *)FixedPcdGetPtr (PcdFirmwareReleaseDateString);
>>>>>>> DateLen = StrLen (DateStr);
>>>>>>> if (DateLen < 3) {
>>>>>>> - DateStr = L"2/2/2022";
>>>>>>> + DateStr = L"02/02/2022";
>>>>>>> DateLen = StrLen (DateStr);
>>>>>>> }
>>>>>>>
>>>>>>
>>>>>> Are you proposing this as an important (but low risk) bugfix that might
>>>>>> qualify for the freeze(s)? If so, please loop in Liming and Mike.
>>>>>>
>>>>>
>>>>> hm... What does freeze mean?
>>>>>
>>>>
>>>> ah... You mean soft feature freeze for edk2-stable202402.
>>>>
>>>> Hi Liming, Michael,
>>>>
>>>> This change is important but low risk. Could you please consider to add it
>>>> to edk2-stable202402 release?
>>>>
>>>> Thanks a lot!
>>>> Joey Lee
>>>
>>> This patch is not in edk2-stable202402. Will it to be merged to next
>>> release?
>>
>> Thanks for the reminder, and sorry about the delay!
>>
>> Merged as commit 2a0d4a2641a7, via
>> <https://github.com/tianocore/edk2/pull/5441>.
>
> Thanks for your review and merge!
>
>>
>> For future contributions: please run PatchCheck.py on the patch series
>> before formatting and posting it (better yet, submit a personal CI build
>> PR).
>>
>
> For 'submit personal CI build PR', I was created a pull requests on github:
> https://github.com/tianocore/edk2/pull/5349
>
> Is it the right approach for triggering a CI build PR?
Yes, it is.
... I think the enforcement of Cc: tags in commit messages may have been
introduced later than your PR. New PRs like yours will catch missing Cc:
tags.
Thanks!
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116483): https://edk2.groups.io/g/devel/message/116483
Mute This Topic: https://groups.io/mt/104153758/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
