On 3/5/24 12:38, Laszlo Ersek wrote: > Bugzillas: > - https://bugzilla.tianocore.org/show_bug.cgi?id=990 > - https://bugzilla.tianocore.org/show_bug.cgi?id=991 > - https://bugzilla.tianocore.org/show_bug.cgi?id=4643 > > CI: > - https://github.com/tianocore/edk2/pull/5442 > > Branch: > - > https://github.com/lersek/edk2/tree/ProcessLibraryConstructorList-SEC-990-991-v2 > > This patch series puts the recent BaseTools feature to use in which > AutoGen generates the ProcessLibraryConstructorList() declaration in > "AutoGen.h" for such non-library SEC modules whose INF_VERSION is at > least 1.30. The BaseTools feature is present in both edk2 [1] and > edk2-basetools [2], and has been documented in the Build spec [3] and > the Inf spec [4]. Kudos to Rebecca for tagging a new edk2-basetools > release [5] [6] with the new feature. > > [1] edk2 commit bac9c74080cf > [2] edk2-basetools commit 5b7161de22ee > [3] edk2-BuildSpecification commit range db69f5661cae..7a7165a7d199 > [4] edk2-InfSpecification commit range a31e3c842bee..1ea6546578fe > [5] https://github.com/tianocore/edk2-basetools/releases/tag/v0.1.51 > [6] https://pypi.org/project/edk2-basetools/0.1.51/ > > The edk2-basetools part is adopted in the first patch (for > "pip-requirements.txt"). > > The rest of the patches clean up -- superfluous, or even incorrect -- > ProcessLibraryConstructorList() declarations (and, in some cases, > incorrect calls), together with raising the INF_VERSIONs in the related > SEC module INF files to 1.30. > > Comparing this version to v1 is not useful, as the compatibility > approach is different, and so this version is structured differently. > Please review any patches for your subsystem from scratch (they are not > difficult or large). > > Cc: Andrei Warkentin <andrei.warken...@intel.com> > Cc: Andrew Fish <af...@apple.com> > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > Cc: Ashraf Ali S <ashraf.al...@intel.com> > Cc: Bob Feng <bob.c.f...@intel.com> > Cc: Catharine West <catharine.w...@intel.com> > Cc: Chasel Chiu <chasel.c...@intel.com> > Cc: Duggapu Chinni B <chinni.b.dugg...@intel.com> > Cc: Erdem Aktas <erdemak...@google.com> > Cc: Gerd Hoffmann <kra...@redhat.com> > Cc: Gua Guo <gua....@intel.com> > Cc: Guo Dong <guo.d...@intel.com> > Cc: James Lu <james...@intel.com> > Cc: Jiewen Yao <jiewen....@intel.com> > Cc: Joey Vagedes <joey.vage...@gmail.com> > Cc: Leif Lindholm <quic_llind...@quicinc.com> > Cc: Liming Gao <gaolim...@byosoft.com.cn> > Cc: Michael D Kinney <michael.d.kin...@intel.com> > Cc: Michael Roth <michael.r...@amd.com> > Cc: Min Xu <min.m...@intel.com> > Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> > Cc: Rahul Kumar <rahul1.ku...@intel.com> > Cc: Ray Ni <ray...@intel.com> > Cc: Rebecca Cran <rebe...@bsdio.com> > Cc: Sami Mujawar <sami.muja...@arm.com> > Cc: Sean Brogan <sean.bro...@microsoft.com> > Cc: Sean Rhodes <sean@starlabs.systems> > Cc: Star Zeng <star.z...@intel.com> > Cc: Sunil V L <suni...@ventanamicro.com> > Cc: Susovan Mohapatra <susovan.mohapa...@intel.com> > Cc: Ted Kuo <ted....@intel.com> > Cc: Tom Lendacky <thomas.lenda...@amd.com> > Cc: Yuwei Chen <yuwei.c...@intel.com> > > Thanks, > Laszlo > > Laszlo Ersek (10): > pip-requirements.txt: require edk2-basetools version 0.1.51 > OvmfPkg: auto-generate (and fix) SEC ProcessLibraryConstructorList() > decl > OvmfPkg/IntelTdx: auto-gen & fix SEC ProcessLibraryConstructorList() > decl > OvmfPkg/RiscVVirt/Sec: clean up ProcessLibraryConstructorList() decl > ArmPlatformPkg: auto-generate SEC ProcessLibraryConstructorList() decl > ArmVirtPkg: auto-generate SEC ProcessLibraryConstructorList() decl > EmulatorPkg: auto-generate SEC ProcessLibraryConstructorList() decl > IntelFsp2Pkg: auto-generate SEC ProcessLibraryConstructorList() decl > UefiCpuPkg: auto-generate SEC ProcessLibraryConstructorList() decl > UefiPayloadPkg: auto-generate SEC ProcessLibraryConstructorList() decl > > ArmPlatformPkg/PrePeiCore/PrePeiCore.h | 10 ---------- > ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf | 2 +- > ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf | 2 +- > ArmPlatformPkg/PrePi/PeiMPCore.inf | 2 +- > ArmPlatformPkg/PrePi/PeiUniCore.inf | 2 +- > ArmPlatformPkg/PrePi/PrePi.h | 6 ------ > ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf | 2 +- > ArmVirtPkg/PrePi/PrePi.c | 6 ------ > EmulatorPkg/Sec/Sec.h | 9 --------- > EmulatorPkg/Sec/Sec.inf | 2 +- > IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf | 2 +- > IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 2 +- > IntelFsp2Pkg/FspSecCore/SecMain.h | 12 > ------------ > OvmfPkg/IntelTdx/Sec/SecMain.c | 3 +-- > OvmfPkg/IntelTdx/Sec/SecMain.inf | 2 +- > OvmfPkg/RiscVVirt/Sec/Memory.c | 1 - > OvmfPkg/RiscVVirt/Sec/SecMain.h | 12 > ------------ > OvmfPkg/RiscVVirt/Sec/SecMain.inf | 2 +- > OvmfPkg/Sec/SecMain.c | 3 +-- > OvmfPkg/Sec/SecMain.inf | 2 +- > UefiCpuPkg/SecCore/SecCore.inf | 2 +- > UefiCpuPkg/SecCore/SecCoreNative.inf | 2 +- > UefiCpuPkg/SecCore/SecMain.h | 12 > ------------ > UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.inf | 2 +- > UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h | 10 ---------- > UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf | 2 +- > UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf | 2 +- > pip-requirements.txt | 4 ++-- > 28 files changed, 20 insertions(+), 100 deletions(-) > > > base-commit: 918288ab5a7c3abe9c58d576ccc0ae32e2c7dea0
Series merged as commit range e60529df58e4..1c0db2315109, via <https://github.com/tianocore/edk2/pull/5450>. One might argue that the last two patches in the series had not been sufficiently reviewed, per strict review process. That may be the case; however, I'm out of time, and this series -- like any other global cleanup series -- only really makes sense if it is as comprehensive as possible. If that's not tolerable, then feel free to revert the UefiCpuPkg and UefiPayloadPkg patches. Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116494): https://edk2.groups.io/g/devel/message/116494 Mute This Topic: https://groups.io/mt/104742520/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
