On 2024-03-12 09:50, Ard Biesheuvel wrote:
On Tue, 12 Mar 2024 at 17:38, Leif Lindholm <quic_llind...@quicinc.com> wrote:
On 2024-03-12 08:17, Ard Biesheuvel wrote:
From: Ard Biesheuvel <a...@kernel.org>
NonCoherentIoMmuSetAttribute() does nothing except return
EFI_UNSUPPORTED. This was fine when it was introduced, but now, the PCI
bus driver will fail a PCI I/O Map() operation if the SetAttributes
fails.
So return EFI_SUCCESS instead.
It's unclear to me why this change is safe (looking forward).
Does NonCoherentIoMmuDxe also imply no IoMmu actually exists?
Basically. NonCoherentIoMmuDxe is just a vehicle to allow
NonCoherentDmaLib to be plugged into the PCI host bridge driver. It is
not intended to ever do anything more than that.
Not that it needs to happen for this
(Reviewed-by: Leif Lindholm <quic_llind...@quicinc.com>)
but maybe we ought to consider renaming it then?
DummyIoMmuDxe?
/
Leif
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116695): https://edk2.groups.io/g/devel/message/116695
Mute This Topic: https://groups.io/mt/104886877/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
