Thanks Phanindra! Reviewed-by: Chasel Chiu <[email protected]>
> -----Original Message----- > From: Pabba, PhanindraX Babu <[email protected]> > Sent: Wednesday, March 27, 2024 2:27 PM > To: [email protected] > Cc: Pabba, PhanindraX Babu <[email protected]>; Chiu, Chasel > <[email protected]>; Desimone, Nathaniel L > <[email protected]>; Liming Gao <[email protected]>; > Dong, Eric <[email protected]> > Subject: [edk2-platforms: PATCH v2] MinPlatformPkg: Add missed call to > FreePool > > From: PhanindraX Babu Pabba <[email protected]> > > Adding missed out call to FreePool API to free the allocated memory. > > Signed-off-by: PhanindraX Babu Pabba <[email protected]> > Cc: Chasel Chiu <[email protected]> > Cc: Nate DeSimone <[email protected]> > Cc: Liming Gao <[email protected]> > Cc: Eric Dong <[email protected]> > --- > Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 5 +++-- > Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c | 1 + > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > index 2a833ec9..9a91d131 100644 > --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > @@ -975,7 +975,7 @@ InstallMcfgFromScratch ( > FixedPcdGet32 (PcdAcpiDefaultOemRevision) > ); > if (EFI_ERROR (Status)) { > - return Status; > + goto Done; > } > > // > @@ -1002,7 +1002,8 @@ InstallMcfgFromScratch ( > McfgTable->Header.Length, > &TableHandle > ); > - > +Done: > + FreePool (McfgTable); > return Status; > } > > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c > b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c > index 9bc22245..f5b1a71c 100644 > --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c > +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c > @@ -195,6 +195,7 @@ PublishAcpiTablesFromFv ( > // Increment the instance > // > Instance++; > + FreePool (CurrentTable); > CurrentTable = NULL; > } > } > -- > 2.39.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117181): https://edk2.groups.io/g/devel/message/117181 Mute This Topic: https://groups.io/mt/105186400/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
