Reviewed-by: Chasel Chiu <[email protected]>
Thanks, Chasel > -----Original Message----- > From: Tan, Dun <[email protected]> > Sent: Sunday, March 31, 2024 11:04 PM > To: [email protected] > Cc: Ni, Ray <[email protected]>; Lou, Yun <[email protected]>; Chiu, Chasel > <[email protected]>; Desimone, Nathaniel L > <[email protected]>; Liming Gao <[email protected]>; > Dong, Eric <[email protected]> > Subject: [edk2-platforms V2 1/3] MinPlatformPkg: Remove the global variable > mForceX2ApicId > > This global variable mForceX2ApicId is not assigned to any value in code and > will > be initialized to 0 when the driver is loaded. So remove the global variable > and > related code that will not be executed. > > Signed-off-by: Dun Tan <[email protected]> > Cc: Ray Ni <[email protected]> > Cc: Jason Lou <[email protected]> > Cc: Chasel Chiu <[email protected]> > Cc: Nate DeSimone <[email protected]> > Cc: Liming Gao <[email protected]> > Cc: Eric Dong <[email protected]> > --- > Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > index 2a833ec99c..62a7da290a 100644 > --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > @@ -53,7 +53,6 @@ VOID *mLocalTable[] = { > EFI_ACPI_TABLE_PROTOCOL *mAcpiTable; > > UINT32 mNumOfBitShift = 6; > -BOOLEAN mForceX2ApicId; > BOOLEAN mX2ApicEnabled; > > EFI_MP_SERVICES_PROTOCOL *mMpService; > @@ -163,14 +162,6 @@ CreateCpuLocalApicInTable ( > CpuIdMapPtr->Thread = ProcessorInfoBuffer.Location.Thread; > CpuIdMapPtr->Flags = ((ProcessorInfoBuffer.StatusFlag & > PROCESSOR_ENABLED_BIT) != 0); > CpuIdMapPtr->SocketNum = ProcessorInfoBuffer.Location.Package; > - > - //update processorbitMask > - if (CpuIdMapPtr->Flags == 1) { > - if (mForceX2ApicId) { > - CpuIdMapPtr->SocketNum &= 0x7; > - CpuIdMapPtr->AcpiProcessorUid &= 0xFF; //keep lower 8bit due to use > Proc obj in dsdt > - } > - } > } else { //not enabled > CpuIdMapPtr->ApicId = (UINT32)-1; > CpuIdMapPtr->Thread = (UINT32)-1; > @@ -1537,7 +1528,6 @@ InstallAcpiPlatform ( > } > > DEBUG ((DEBUG_INFO, "mX2ApicEnabled - 0x%x\n", mX2ApicEnabled)); > - DEBUG ((DEBUG_INFO, "mForceX2ApicId - 0x%x\n", mForceX2ApicId)); > > // support up to 64 threads/socket > AsmCpuidEx (CPUID_EXTENDED_TOPOLOGY, 1, &mNumOfBitShift, NULL, NULL, > NULL); > -- > 2.31.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117327): https://edk2.groups.io/g/devel/message/117327 Mute This Topic: https://groups.io/mt/105259123/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
