[AMD Official Use Only - General] Hi Ard,
This checkin causes VanGoghBoard build fail now. Would you help revert it? I will merge PATCH to VanGoghBoard after the code review process done and code changes are verified pass on real board. Thanks, Eric > -----Original Message----- > From: Ard Biesheuvel <a...@kernel.org> > Sent: Friday, April 19, 2024 4:27 PM > To: devel@edk2.groups.io; Xing, Eric <eric.x...@amd.com> > Cc: Zhai, MingXin (Duke) <duke.z...@amd.com>; Lendacky, Thomas > <thomas.lenda...@amd.com>; Chang, Abner <abner.ch...@amd.com>; > Yao, Ken <ken....@amd.com>; Roth, Michael <michael.r...@amd.com>; > Attar, AbdulLateef (Abdul Lateef) <abdullateef.at...@amd.com>; Ard > Biesheuvel <ardb+tianoc...@kernel.org>; Gerd Hoffmann > <kra...@redhat.com>; Min Xu <min.m...@intel.com>; Leif Lindholm > <quic_llind...@quicinc.com> > Subject: Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to > required DSC files > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > On Fri, 19 Apr 2024 at 10:10, Xing, Eric via groups.io > <eric.xing=amd....@groups.io> wrote: > > > > [AMD Official Use Only - General] > > > > > > Thanks Duke. > > > > > > > > Hi Thomas, > > > > > > > > PATCH1/2 still cannot be checked in because today’s VanGoghBoard is > based off EDK2_202208. Please hold on this PATCH check in. > > > > > > Apologies, but I already merged this patch two days ago. > > edk2-platforms should build in combination with edk2. If your platform has > other dependencies that are not in edk2, edk2-platforms or edk2-non-osi, > please host and maintain the platform elsewhere. > > I also noticed that > Platform/AMD/VanGoghBoard/ChachaniBoardPkg/build.sh requires that the > various repo checkouts are inside the workspace, but the BaseTools don't > actually require this. Personally, I use > > $HOME/edk2-workspace for the builds > > $HOME/edk2 > $HOME/edk2-platforms > $HOME/edk2-non-osi > > for the checkouts, which keeps things separate, and allow me to wipe the > workspace entirely without touching the repos. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118014): https://edk2.groups.io/g/devel/message/118014 Mute This Topic: https://groups.io/mt/105537744/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
